Skip to content

updating documentation for CRF #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 23, 2020
Merged

updating documentation for CRF #2168

merged 7 commits into from
Sep 23, 2020

Conversation

Harsh188
Copy link
Contributor

@Harsh188 Harsh188 commented Sep 16, 2020 •
edited
Loading

Description

Improving documentation for layers/crf.py

Fixes part of #337

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

@boring-cyborg boring-cyborg bot added the layers label Sep 16, 2020
@Harsh188
Copy link
Contributor Author

I have no idea what's wrong with this. When I run pytest -v --doctest-modules tensorflow_addons/layers/crf.py I get no errors.

WindQAQ
WindQAQ reviewed Sep 20, 2020
View reviewed changes
Copy link
Member

@WindQAQ WindQAQ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! One minor request: some sentences miss period.

@WindQAQ
Copy link
Member

WindQAQ commented Sep 22, 2020

Hi, I find that we forget to import CRF in __init__.py. Can you also import it in this PR?

from tensorflow_addons.layers.crf import CRF

https://github.com/tensorflow/addons/blob/master/tensorflow_addons/layers/__init__.py

@Harsh188 Harsh188 requested a review from WindQAQ September 23, 2020 02:53
@WindQAQ WindQAQ merged commit 2cd311a into tensorflow:master Sep 23, 2020
@bot-of-gabrieldemarmiesse bot-of-gabrieldemarmiesse mentioned this pull request Sep 23, 2020
Merged
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@Harsh188
updating documentation for CRF (tensorflow#2168)
b3c94be 
* updating documentation for CRF

* changing output type

* fixing grammar issues

* reformatted

* reformatting to avoid long lines

* reformat

* reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WindQAQ WindQAQ WindQAQ approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@seanpmorgan seanpmorgan Awaiting requested review from seanpmorgan

Assignees
No one assigned
Labels
backport r0.11 cla: yes layers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harsh188 @WindQAQ @googlebot @seanpmorgan