Skip to content

Function ops #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 26, 2021
Merged

Function ops #327

merged 14 commits into from
Jun 26, 2021

Conversation

rnett
Copy link
Contributor

@rnett rnett commented May 31, 2021

Generates ops that take functions as parameters.

@karllessard
Copy link
Collaborator

@rnett any way you can split that in multiple smaller PRs?

@rnett
Copy link
Contributor Author

rnett commented Jun 1, 2021

Yikes, I'm not sure why it changed all the op classes.

@rnett
Copy link
Contributor Author

rnett commented Jun 1, 2021

Ok @karllessard, the big change is in #328, I haven't applied it. If you merge that PR I'll do another one with the generation, and then this one will be smaller after rebasing.

@rnett
Copy link
Contributor Author

rnett commented Jun 1, 2021

Also @JimClarke5 this is what I was talking about wrt the runtime initialization checks, you should be able to use ifOp for that without too much trouble. Although I'm not sure it's a great idea, and I'm working on the init scope PR (and variables soonish after that).

@karllessard
Copy link
Collaborator

@rnett can you please rebase this PR now that we are on TF2.5? I guess new ops might also be added?

@rnett
Copy link
Contributor Author

rnett commented Jun 16, 2021

I'm going to wait until #328 if you think you can merge it quickly, since this one needs to be rebased on top of it anyways.

@rnett rnett force-pushed the rn_function_ops branch from a479d7c to e33bfff Compare June 16, 2021 02:28
@rnett
Copy link
Contributor Author

rnett commented Jun 16, 2021

Ok, it's rebased. The number of files is smaller, but still pretty big since the generation is in there. I can try to make it smaller if you want, but if you need to check for groups it might be required anyways.

@karllessard
Copy link
Collaborator

The number of files if fine, since most of the are generated (so I don't need to spend time reviewing them). Some ops needs to be reclassified into the right package though (like ReduceDataset).

@rnett rnett force-pushed the rn_function_ops branch from e33bfff to 69d4600 Compare June 25, 2021 06:43
@google-cla
Copy link

google-cla bot commented Jun 26, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@karllessard
Copy link
Collaborator

@googlebot I consent.

@karllessard karllessard merged commit 81fb7e7 into tensorflow:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants