-
Notifications
You must be signed in to change notification settings - Fork 214
Function ops #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function ops #327
Conversation
@rnett any way you can split that in multiple smaller PRs? |
Yikes, I'm not sure why it changed all the op classes. |
Ok @karllessard, the big change is in #328, I haven't applied it. If you merge that PR I'll do another one with the generation, and then this one will be smaller after rebasing. |
Also @JimClarke5 this is what I was talking about wrt the runtime initialization checks, you should be able to use |
@rnett can you please rebase this PR now that we are on TF2.5? I guess new ops might also be added? |
I'm going to wait until #328 if you think you can merge it quickly, since this one needs to be rebased on top of it anyways. |
Ok, it's rebased. The number of files is smaller, but still pretty big since the generation is in there. I can try to make it smaller if you want, but if you need to check for groups it might be required anyways. |
The number of files if fine, since most of the are generated (so I don't need to spend time reviewing them). Some ops needs to be reclassified into the right package though (like |
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Generates ops that take functions as parameters.