Use OP_NAME constant instead of hard coding #328
Merged
+1,447
−1,433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Ok @rnett , I would really like to simplify the review process to speed up PR merging. In this PR, it looks like 99% of the changes are reformatting again. So here's what I propose:
Let's experiment this out, wdyt? |
rnett
force-pushed
the
rn_op_generation_updates
branch
from
772aa17 to
57a3d8e
Compare
|
Ok, I pushed format-less changes. I'll do the formatting and op generation once you approve it. |
karllessard
previously approved these changes
Jun 1, 2021
|
Op generation is done. |
|
@rnett sorry but I think you'll need to rebase again, since we've merged TF2.5 not long ago |
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
rnett
force-pushed
the
rn_op_generation_updates
branch
from
98a5052 to
f3bd66a
Compare
|
@karllessard it's rebased. |
Signed-off-by: Ryan Nett <[email protected]>
karllessard
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for op generation, results in lots of changed files.