Skip to content

Add description of file:// save and load in tfjs-node #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 9, 2018

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Jun 7, 2018

Towards: tensorflow/tfjs#343


This change is Reviewable

@caisq caisq requested review from tafsiri and nkreeger June 7, 2018 17:18
@tafsiri
Copy link
Contributor

tafsiri commented Jun 7, 2018

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


source/tutorials/model-save-load.md, line 200 at r1 (raw file):

To achieve the latter, you simply serve the files as static files from your

I'd suggest removing 'you simply'.


source/tutorials/model-save-load.md, line 201 at r1 (raw file):

To achieve the latter, you simply serve the files as static files from your
web server. These files can also be converted to the HDF5 format of Python Keras

This part is a bit confusing to me, i thought the converter converted HDF5 files into the .json and .bin format? In the context of this tutorial it may be unclear why one would want to convert to HDF5. I lean towards removing this sentence, but maybe i just don't understand where you were going with it.


Comments from Reviewable

@caisq
Copy link
Contributor Author

caisq commented Jun 8, 2018

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


source/tutorials/model-save-load.md, line 200 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

I'd suggest removing 'you simply'.

Done.


source/tutorials/model-save-load.md, line 201 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

This part is a bit confusing to me, i thought the converter converted HDF5 files into the .json and .bin format? In the context of this tutorial it may be unclear why one would want to convert to HDF5. I lean towards removing this sentence, but maybe i just don't understand where you were going with it.

I reworded this sentence a little to provide motivation for why one would care about tensorflowjs_converter in this case.


Comments from Reviewable

@tafsiri
Copy link
Contributor

tafsiri commented Jun 8, 2018

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@nkreeger
Copy link
Contributor

nkreeger commented Jun 8, 2018

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


Comments from Reviewable

@caisq caisq merged commit 9b1048d into tensorflow:master Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants