Skip to content

Implement IOHandlers in TensorFlow.js Node.js binding #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
caisq opened this issue May 25, 2018 · 3 comments
Closed

Implement IOHandlers in TensorFlow.js Node.js binding #343

caisq opened this issue May 25, 2018 · 3 comments
Assignees
@caisq
Labels
comp:node.js type:feature New feature or request

Comments

@caisq
Copy link
Contributor

caisq commented May 25, 2018

TensorFlow.js version

0.11.2

The scope may include:

  • IOHandler implementation for native filesystem
  • IOHandler implementation for node.js fetch.
@caisq caisq added type:feature New feature or request comp:node.js labels May 25, 2018
@caisq
Copy link
Contributor Author

caisq commented May 25, 2018

cc @nkreeger

This was referenced May 25, 2018
Closed
Closed
@caisq caisq self-assigned this Jun 1, 2018
This was referenced Jun 1, 2018
Merged
Merged
This was referenced Jun 10, 2018
Closed
Merged
caisq added a commit to caisq/tfjs-layers-1 that referenced this issue Jun 12, 2018
@caisq
No-scheme relative path should be routed to HTTP handler only in browser
d51d3a1 
* Currently, a call like tf.loadModel('./model.json') will be routed
  to tf.io.browserHTTPRequest regardless of whether the environment is
  browser or node.js. This will cause issues for node.js.
  This change makes it so that this routing of relative paths to
  browserHTTPRequest (using browser `fetch`) is done only in the
  browser. This implies that paths without a scheme is not supported.
  In other words, in node.js, a path given to tf.loadModel must have a
  scheme, e.g., tf.loadModel('file://./mode.json'),
  tf.loadModel('https://localhost/model.json').

Towards: tensorflow/tfjs#343
@caisq caisq mentioned this issue Jun 12, 2018
Closed
@nkreeger
Copy link
Contributor

@caisq this should be closed now right?

@caisq
Copy link
Contributor Author

caisq commented Oct 24, 2018

@nkreeger yep

@caisq caisq closed this as completed Oct 24, 2018
@caisq caisq mentioned this issue Dec 12, 2018
Merged
caisq added a commit to tensorflow/tfjs-node that referenced this issue Dec 13, 2018
@caisq
Remove the need to override global.fetch for HTTP/HTTPS loading in …
bac3ba1 
…tfjs-node (#182)

FEATURE

Fixes tensorflow/tfjs#410 tensorflow/tfjs#343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caisq caisq

Labels
comp:node.js type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkreeger @caisq