TypeError: Cannot read property 'name' of undefined for no-debug

[tdeekens]

We adopted the react preset recently and are seeing failing builds on CI with the error TypeError: Cannot read property 'name' of undefined. Which seems to originate from this code:

ImportDeclaration(node) {
    const screenModuleName = LIBRARY_MODULES_WITH_SCREEN.find(
      module => module === node.source.value
    );

    if (
      screenModuleName &&
      node.specifiers.some(
        specifier => specifier.imported.name === 'screen'
      )
    ) {
      hasImportedScreen = true;
    }
},

in no-debug.js on line 95.

We are also seeing the error on a GitHub Action build to inspect for you.

https://github.com/commercetools/merchant-center-application-kit/pull/1419/checks?check_run_id=544774992

[Belco90]

Hey Tobias, thanks for reporting the error. Sorry about this, I'll take a look a it this morning, should be easy to fix. Pretty awesome how much info you added to the issue :)

[tdeekens]

You're welcome. I do some Open Source myself so I know how hard (also emotionally) it can be to get an issue with little to no context 😄. Thanks for the quick response.

[Belco90]

I found the issue: wildcard imports like import * as rtl from '@testing-library/react'; are not taken into account properly. Checking how to fix it properly.

[Belco90]

@tdeekens fixed btw, just waiting for the PR to be approved. I'm checking meanwhile another rule that could be affected by the same issue!

[tdeekens]

Wow, super fast. Thanks!

[Belco90]

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[tdeekens]

Thanks bot. Thanks human :)

[Belco90]

@all-contributors please add @tdeekens for bug

[allcontributors]

@Belco90

I've put up a pull request to add @tdeekens! 🎉