Skip to content

fix: check namespaced import properly for no-debug and prefer-wait-for #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2020
Merged

fix: check namespaced import properly for no-debug and prefer-wait-for #102

merged 3 commits into from
Mar 31, 2020

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Mar 30, 2020

Closes #101

@Belco90 Belco90 self-assigned this Mar 30, 2020
@Belco90 Belco90 changed the title fix(no-debug): check namespaced import properly fix: check namespaced import properly for no-debug and prefer-wait-for Mar 30, 2020
@Belco90
Copy link
Member Author

Belco90 commented Mar 30, 2020

Same issue fixed for prefer-wait-for rule fixer.

timdeschryver
timdeschryver approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
On a side note, I don't like all these different ways to import while working on linters 😅

@Belco90
Copy link
Member Author

Belco90 commented Mar 31, 2020

LGTM
On a side note, I don't like all these different ways to import while working on linters 😅

Yeah, me either. We have mentioned few times in different PRs that we should migrate the plugin to TS so we can use TSESLint experimental utils. It would probably help to use generic methods to check this kind of things.

@Belco90 Belco90 merged commit 6c8f14a into master Mar 31, 2020
@Belco90 Belco90 deleted the pr/issue-101 branch March 31, 2020 07:08
@Belco90
Copy link
Member Author

Belco90 commented Mar 31, 2020

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

@emmenko emmenko Awaiting requested review from emmenko

Assignees

@Belco90 Belco90

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'name' of undefined for no-debug
2 participants
@Belco90 @timdeschryver