Skip to content

feat: support assignments and promise syntax #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

thomaslombart
Copy link
Collaborator

This PR intends to support the edge cases of the queries usage. That is to say:

  • Assignments of the queries :
const promise = findByText('foo')
return promise
  • Promise syntax
const promise = findByText('foo')
promise.then(node => done())

// Or

findByText('foo').then(node => {
  done()
})

All tests passes but I consider the implementation to be a bit fragile.

Closes #1
Closes #2

@thomaslombart thomaslombart self-assigned this Sep 16, 2019
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'm learning lot of things about AST with this plugin :)

@Belco90 Belco90 changed the title feat: support assignements and promise syntax feat: support assignments and promise syntax Sep 16, 2019
@Belco90 Belco90 merged commit 8246af4 into master Sep 16, 2019
@Belco90 Belco90 deleted the feature/support-assignements-and-promise-syntax branch September 16, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support assignments and awaiting them Support promise-syntax
2 participants