Skip to content

Remove specific adoptions from README #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Conversation

trishankkarthik
Copy link
Contributor

Fixes issue #:

As per theupdateframework/theupdateframework.io#10

Description of the changes being introduced by the pull request:

Update list of adoptions

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@joshuagl
Copy link
Member

LGTM. The DCO checks are failing because none of the commit headers have a Signed-off-by line

Update list of adoptions

Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Use a single source of truth on the .io website

Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Point to .io website for adoptions instead of duplicating information

Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
@trishankatdatadog trishankatdatadog force-pushed the trishankkarthik-patch-1 branch from 2c323a2 to 0f0bce5 Compare July 21, 2020 16:14
@trishankatdatadog trishankatdatadog changed the title Update README.md Remove adoptions from README Jul 21, 2020
@JustinCappos
Copy link
Member

JustinCappos commented Jul 21, 2020 via email

@trishankatdatadog
Copy link
Member

It seems a bit extreme to delete the adopters list from both the README and the ADOPTERS.md from the site. I'd prefer we update the content to make it more accurate instead...

The problem is in maintaining more than one source of truth for adoptions: one on theupdateframework.io and here. Seems best to maintain one well-curated one...

@trishankatdatadog trishankatdatadog changed the title Remove adoptions from README Remove specific adoptions from README Jul 21, 2020
@JustinCappos
Copy link
Member

It seems a bit extreme to delete the adopters list from both the README and the ADOPTERS.md from the site. I'd prefer we update the content to make it more accurate instead...

The problem is in maintaining more than one source of truth for adoptions: one on theupdateframework.io and here. Seems best to maintain one well-curated one...

Got it. Makes sense to me.

Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trishankatdatadog
Copy link
Member

Got it. Makes sense to me.

I can't merge because some flaky tests prevent me. Please feel free to merge, thanks!

@JustinCappos JustinCappos merged commit bba2375 into develop Jul 21, 2020
@joshuagl joshuagl mentioned this pull request Aug 4, 2020
3 tasks
@trishankatdatadog trishankatdatadog deleted the trishankkarthik-patch-1 branch October 13, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants