-
Notifications
You must be signed in to change notification settings - Fork 278
Remove specific adoptions from README #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM. The DCO checks are failing because none of the commit headers have a Signed-off-by line |
Update list of adoptions Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Use a single source of truth on the .io website Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
Point to .io website for adoptions instead of duplicating information Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
2c323a2
to
0f0bce5
Compare
It seems a bit extreme to delete the adopters list from both the README and
the ADOPTERS.md from the site. I'd prefer we update the content to make it
more accurate instead...
…On Tue, Jul 21, 2020 at 12:15 PM Trishank Karthik Kuppusamy < ***@***.***> wrote:
@trishankatdatadog <https://github.com/trishankatdatadog> requested your
review on: #1086 <#1086>
Update README.md.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1086 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGROD5ETRX427M77N75LP3R4W5J3ANCNFSM4PAEONJQ>
.
|
The problem is in maintaining more than one source of truth for adoptions: one on theupdateframework.io and here. Seems best to maintain one well-curated one... |
Got it. Makes sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can't merge because some flaky tests prevent me. Please feel free to merge, thanks! |
Fixes issue #:
As per theupdateframework/theupdateframework.io#10
Description of the changes being introduced by the pull request:
Update list of adoptions
Please verify and check that the pull request fulfills the following
requirements: