Skip to content

Update adoptions.yaml #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

trishankatdatadog
Copy link
Member

Could not find VMware or DigitalOcean adoption anymore. Please double-check.

@joshuagl
Copy link
Member

joshuagl commented Jul 15, 2020

The VMware adoption was Harbor, but that's no longer a VMware owned project – it was donated to the CNCF.

@trishankatdatadog
Copy link
Member Author

The VMware adoption was Harbor, but that's no longer a VMware owned project – it was donated to the CNCF.

That explains it. Thanks! We should still remove, I guess.

@joshuagl
Copy link
Member

joshuagl commented Jul 17, 2020

AFAIK we should remove VMware.

I haven't been able to figure out if the OPAM integration is still ongoing or not. Even if it is, do we consider conex to be a TUF implementation or a TUF inspired system?

It's not clear to me where we want to draw the line with integrations that aren't 100% TUF but are definitely inspired by TUF. The recent Guix work also comes to mind, in that it cites TUF. My understanding is that Conex is ~= a TUF implementation/integration but the Guix approach is only inspired by, though I admit I've not dug into either (only read blog posts).

@JustinCappos
Copy link
Member

Okay, what about DigitalOcean?

@trishankatdatadog
Copy link
Member Author

I haven't been able to figure out if the OPAM integration is still ongoing or not. Even if it is, do we consider conex to be a TUF implementation or a TUF inspired system?

It's not clear to me where we want to draw the line with integrations that aren't 100% TUF but are definitely inspired by TUF. The recent Guix work also comes to mind, in that it cites TUF. My understanding is that Conex is ~= a TUF implementation/integration but the Guix approach is only inspired by, though I admit I've not dug into either (only read blog posts).

Agreed. Maybe we should say something like "Inspired by", but not "Ongoing integrations".

@trishankatdatadog
Copy link
Member Author

Okay, what about DigitalOcean?

Can't find any references to TUF or Notary in the current code, please double-check.

@joshuagl
Copy link
Member

I haven't been able to figure out if the OPAM integration is still ongoing or not. Even if it is, do we consider conex to be a TUF implementation or a TUF inspired system?
It's not clear to me where we want to draw the line with integrations that aren't 100% TUF but are definitely inspired by TUF. The recent Guix work also comes to mind, in that it cites TUF. My understanding is that Conex is ~= a TUF implementation/integration but the Guix approach is only inspired by, though I admit I've not dug into either (only read blog posts).

Agreed. Maybe we should say something like "Inspired by", but not "Ongoing integrations".

+1 from me. Maybe with smaller logos, or no logo, to de-emphasise them?

@trishankatdatadog
Copy link
Member Author

+1 from me. Maybe with smaller logos, or no logo, to de-emphasise them?

Right, and we can even mark some integrations as abandoned (like Rubygems), if so desired.

@JustinCappos
Copy link
Member

JustinCappos commented Jul 17, 2020 via email

@trishankatdatadog
Copy link
Member Author

I'm not sure what to do with "inspired"... Maybe a separate section, but it feels like we would need them to do a post or some other public mention for us to point to.

Should we just remove them for now, then?

@JustinCappos
Copy link
Member

JustinCappos commented Jul 17, 2020 via email

@trishankatdatadog
Copy link
Member Author

It makes sense to me. I don't want to be accused of overclaiming, especially by someone in that community.

Ok, let me know what to remove, and I'll do it.

JustinCappos
JustinCappos previously approved these changes Jul 18, 2020
Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustinCappos
Copy link
Member

If we're removing VMware, shouldn't the main page be fixed too? https://deploy-preview-10--theupdateframework.netlify.app/

@JustinCappos JustinCappos dismissed their stale review July 18, 2020 19:14

Main page content needs update too.

@trishankatdatadog
Copy link
Member Author

Main page content needs update too.

Done. Anywhere else?

Also see theupdateframework/python-tuf#1086

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, @trishankatdatadog! There are still a couple of tiny issues left.

@trishankatdatadog
Copy link
Member Author

All, did some serious pruning, perhaps a bit overboard, but please take a look.

@trishankatdatadog
Copy link
Member Author

cc @mnm678

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the big sweep! There is one link that does not resolve (see inline). Also, would you mind squashing your commits and adding a note to the commit message that explains why you removed certain projects, for each of those projects?

Added:
* CNAB Security.

Replaced:
* Amazon with Bottlerocket.
* Google with Fuchsia.
* ATS with HERE.

Removed:
* VMware because Harbor now transfered to CNCF.
* DigitalOcean because their do-agent no longer seems to use Notary.
* RubyGems because the Square PR has never been merged.
* IBM container registry because redundant with Notary.
* Azure container registry because redundant with Notary.
* Docker because original blog post seems to be gone; also, redundant
with Notary.
* Quay because no more reference to using Notary.
* LEAP because Bitmask no longer seems to be using TUF.

Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
@trishankatdatadog
Copy link
Member Author

Thanks for the big sweep! There is one link that does not resolve (see inline). Also, would you mind squashing your commits and adding a note to the commit message that explains why you removed certain projects, for each of those projects?

Done

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for addressing my comments! 🎉 LGTM

@lukpueh lukpueh merged commit b070264 into theupdateframework:master Sep 1, 2020
@trishankatdatadog trishankatdatadog deleted the patch-2 branch September 1, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants