Version Packages #7826
Version Packages #7826
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughRemoved several changeset files, added/updated changelog entries for thirdweb, nebula, and wagmi-adapter, and bumped package versions for thirdweb, nebula, and wagmi-adapter. The thirdweb changelog records deprecation of Bridge.routes' sortBy parameter. No source code or exported APIs were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (9)
💤 Files with no reviewable changes (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog header added for 0.2.129Header matches package.json. Since this is a metadata-only release, an empty entry is fine. LGTM.
Consider adding a brief line like “No code changes; version bump via changesets” for future clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/shaky-candles-rule.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/shaky-candles-rule.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit Inference Engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/wagmi-adapter/package.json (1)
58-58: Version bump aligns with release intentVersion updated to 0.2.129; consistent with the changelog. No API/deps changes detected. LGTM.
packages/thirdweb/CHANGELOG.md (1)
3-8: Changelog entry is clear and correctly linkedDeprecation of Bridge.routes sortBy is documented with proper PR/commit links. LGTM.
packages/nebula/package.json (1)
60-60: Nebula version bumped to 0.2.32Aligned with the dependency update to [email protected]. No other changes. LGTM.
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry looks correct and consistent.
- Version header, spacing, and bullet formatting match prior entries.
- Commit link and updated dependency version align with the release note.
| @@ -409,5 +409,5 @@ | |||
| } | |||
| }, | |||
| "typings": "./dist/types/exports/thirdweb.d.ts", | |||
| "version": "5.105.31" | |||
| "version": "5.105.32" | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Patch release version updated
Set to 5.105.32, matching the new changelog entry. LGTM.
To ensure the deprecation of Bridge.routes sortBy is fully reflected, you can scan for remaining references and update JSDoc/types as needed:
🏁 Script executed:
#!/bin/bash
# Search for Bridge.routes and any 'sortBy' usage across the repo
rg -n --no-ignore -S $'Bridge\\.routes\\(|sortBy' | sed 's/^/~/'
# Optionally, list TS definitions mentioning sortBy
rg -n --no-ignore -S $'sortBy' --glob '*.ts' --glob '*.d.ts'Length of output: 12766
Ensure complete deprecation of the Bridge.routes sortBy option
Although the version was bumped to 5.105.32, references to options.sortBy remain throughout the codebase. Please update all JSDoc, types, implementation, hooks, and tests to either remove or mark this parameter as deprecated—and, if desired, emit a runtime warning when it’s used.
• packages/thirdweb/src/bridge/Routes.ts
– Add @deprecated to @param options.sortBy in the JSDoc
– Mark or remove the sortBy?: "popularity"; field in the BridgeRoutesOptions type (around line 210)
– Deprecate or remove the if (sortBy) url.searchParams.set("sortBy", sortBy); block (around lines 160–161)
• packages/thirdweb/src/react/core/hooks/useBridgeRoutes.ts (+ its test)
– Stop passing sortBy through to Bridge.routes (or mark it deprecated)
– Update the test in useBridgeRoutes.test.ts to reflect removal/deprecation
• apps/dashboard/src/(app)/(dashboard)/(bridge)/utils.ts
– Remove or deprecate any hard-coded sortBy values on Bridge route utils
🤖 Prompt for AI Agents
In packages/thirdweb/package.json at line 412 and associated files
(packages/thirdweb/src/bridge/Routes.ts around lines ~160 and ~210,
packages/thirdweb/src/react/core/hooks/useBridgeRoutes.ts and its test
useBridgeRoutes.test.ts, and
apps/dashboard/src/(app)/(dashboard)/(bridge)/utils.ts), remove or mark the
Bridge.routes options.sortBy as deprecated: add @deprecated to the @param
options.sortBy JSDoc in Routes.ts, update the BridgeRoutesOptions type to either
remove the sortBy?: "popularity" field or mark it deprecated in the type
comment, remove or deprecate the runtime block that sets
url.searchParams.set("sortBy", sortBy) (around lines 160–161) or replace it with
a runtime console.warn if you choose to keep backward compatibility, stop
passing sortBy from useBridgeRoutes and update its test to reflect the change
(remove assertions expecting sortBy to be forwarded or assert a deprecation
warning), and remove or deprecate any hard-coded sortBy usages in the dashboard
bridge utils, ensuring tests and types are adjusted accordingly.
size-limit report 📦
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
2b9b82c to
134a243
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (2)
7-8: Clarify deprecation impact and next steps for usersConsider explicitly stating:
- Whether
sortByis now a no-op or still honored (and since which version).- The default sorting behavior going forward.
- When the parameter will be removed, and if any alternative exists.
This helps consumers assess urgency and make changes proactively.
9-10: Specify scope and configurability of the UI change“Hide quote value in payment widgets” could mention:
- Which widgets (BuyWidget, CheckoutWidget, TransactionWidget, etc.).
- Whether this is the new default vs. gated behind a prop/option.
- Any path to re-enable it (for integrators who rely on it).
Also ensure related docs reflect the change so users aren’t surprised by the new default.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/shaky-candles-rule.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/shaky-candles-rule.md
✅ Files skipped from review due to trivial changes (1)
- packages/nebula/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/nebula/package.json
- packages/wagmi-adapter/package.json
- packages/thirdweb/package.json
- packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/thirdweb/CHANGELOG.md (1)
3-6: Changelog entry format looks goodVersion heading and Patch classification are consistent with prior sections. No issues spotted.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7826 +/- ##
=======================================
Coverage 56.33% 56.33%
=======================================
Files 905 905
Lines 58834 58834
Branches 4151 4158 +7
=======================================
+ Hits 33146 33147 +1
Misses 25582 25582
+ Partials 106 105 -1
🚀 New features to boost your workflow:
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
134a243 to
741f16e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (2)
9-10: Consider adding a brief usage snippet for TikTok auth.A one-liner example (consistent with past changelog entries) helps discovery.
- - [#7817](https://github.com/thirdweb-dev/js/pull/7817) [`66c7df9`](https://github.com/thirdweb-dev/js/commit/66c7df98e42dc7b5168b817e3f9a179349479d62) Thanks [@0xFirekeeper](https://github.com/0xFirekeeper)! - Adds TikTok as a new authentication method for In-App and Ecosystem Wallets. + - [#7817](https://github.com/thirdweb-dev/js/pull/7817) [`66c7df9`](https://github.com/thirdweb-dev/js/commit/66c7df98e42dc7b5168b817e3f9a179349479d62) Thanks [@0xFirekeeper](https://github.com/0xFirekeeper)! - Adds TikTok as a new authentication method for In-App and Ecosystem Wallets. + ```ts + const wallet = inAppWallet(); + await wallet.connect({ client, strategy: "tiktok" }); + ```
11-11: Clarify what “quote value” refers to and normalize punctuation.Be explicit (e.g., “fiat quote value”) and end with a period to match adjacent entries.
- - [#7827](https://github.com/thirdweb-dev/js/pull/7827) [`90f36bc`](https://github.com/thirdweb-dev/js/commit/90f36bc414a8f29b9794d3d6a15e2d3e145eca7c) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Hide quote value in payment widgets + - [#7827](https://github.com/thirdweb-dev/js/pull/7827) [`90f36bc`](https://github.com/thirdweb-dev/js/commit/90f36bc414a8f29b9794d3d6a15e2d3e145eca7c) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Hides the fiat quote value in payment widgets.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.changeset/shaky-candles-rule.md(0 hunks).changeset/warm-ways-decide.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/warm-ways-decide.md
- .changeset/shaky-candles-rule.md
✅ Files skipped from review due to trivial changes (1)
- packages/wagmi-adapter/package.json
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/thirdweb/package.json
- packages/wagmi-adapter/CHANGELOG.md
- packages/nebula/CHANGELOG.md
- packages/nebula/package.json
🔇 Additional comments (1)
packages/thirdweb/CHANGELOG.md (1)
3-12: LGTM: Changelog entry matches release intentThe three patch notes accurately reflect the PR objectives for 5.105.32. Links, hashes, and scope look consistent with prior entries.
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Add deprecation guidance and timeline for Bridge.routes({ sortBy }).
Deprecation notices are more useful with next-steps and a rough removal target. Suggest clarifying default behavior and when removal may occur. Also add a terminal period for consistency.
Proposed tweak:
- - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes
+ - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in `Bridge.routes`.
+ The `sortBy` argument will be removed in a future major release; please remove it from any calls.
+ Routes are returned in the default order provided by the service.Optional verification script to ensure code is annotated with a deprecation marker:
🏁 Script executed:
#!/bin/bash
# Verify `sortBy` usages and @deprecated annotations
rg -n "Bridge\.routes" -A 10 -B 2
rg -n "sortBy" -A 2 -B 2
rg -n "@deprecated.*sortBy" -A 2 -B 2Length of output: 60883
Update CHANGELOG.md with deprecation guidance and timeline
The deprecation notice for sortBy in Bridge.routes should include next steps, a removal target, default behavior, and end with a period for consistency.
• File: packages/thirdweb/CHANGELOG.md
Line: 7
- - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes
+ - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in `Bridge.routes`.
+ The `sortBy` argument will be removed in a future major release; please remove it from any calls.
+ Routes are returned in the default order provided by the service.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes | |
| - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in `Bridge.routes`. | |
| The `sortBy` argument will be removed in a future major release; please remove it from any calls. | |
| Routes are returned in the default order provided by the service. |
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md around line 7, the deprecation note for
`sortBy` in Bridge.routes is missing guidance and punctuation; update that line
to: add a short "Next steps" paragraph advising users how to migrate (e.g., use
the new param or omit), state the removal target (version or date) and the
default behavior after removal, and ensure the sentence ends with a period for
consistency.
741f16e to
a988dcd
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
0d7e5e5,a77e98a,66c7df9,90f36bc]:[email protected]
Patch Changes
#7844
0d7e5e5Thanks @gregfromstl! - Fix SDK resolution in environements where process is undefined#7825
a77e98aThanks @gregfromstl! - DeprecatessortByparameter in Bridge.routes#7817
66c7df9Thanks @0xFirekeeper! - Adds TikTok as a new authentication method for In-App and Ecosystem Wallets.#7827
90f36bcThanks @gregfromstl! - Hide quote value in payment widgets@thirdweb-dev/[email protected]
PR-Codex overview
This PR primarily focuses on updating version numbers across several packages and providing changelogs for
thirdwebandnebula, detailing recent improvements and fixes.Detailed summary
.changesetmarkdown files.versioninpackages/thirdweb/package.jsonfrom5.105.31to5.105.32.versioninpackages/nebula/package.jsonfrom0.2.31to0.2.32.versioninpackages/wagmi-adapter/package.jsonfrom0.2.128to0.2.129.nebulaversion0.2.32andthirdwebversion5.105.32detailing patch changes and fixes.Summary by CodeRabbit