Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/fine-zoos-own.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/shaky-candles-rule.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/slick-cups-joke.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/warm-ways-decide.md

This file was deleted.

7 changes: 7 additions & 0 deletions packages/nebula/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @thirdweb-dev/nebula

## 0.2.32

### Patch Changes

- Updated dependencies [[`0d7e5e5`](https://github.com/thirdweb-dev/js/commit/0d7e5e563d142d178005469e31ea3423e6daacf1), [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f), [`66c7df9`](https://github.com/thirdweb-dev/js/commit/66c7df98e42dc7b5168b817e3f9a179349479d62), [`90f36bc`](https://github.com/thirdweb-dev/js/commit/90f36bc414a8f29b9794d3d6a15e2b3e145eca7c)]:
- [email protected]

## 0.2.31

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/nebula/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,5 @@
"type": "module",
"types": "./dist/types/exports/thirdweb.d.ts",
"typings": "./dist/types/exports/thirdweb.d.ts",
"version": "0.2.31"
"version": "0.2.32"
}
12 changes: 12 additions & 0 deletions packages/thirdweb/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# thirdweb

## 5.105.32

### Patch Changes

- [#7844](https://github.com/thirdweb-dev/js/pull/7844) [`0d7e5e5`](https://github.com/thirdweb-dev/js/commit/0d7e5e563d142d178005469e31ea3423e6daacf1) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Fix SDK resolution in environements where process is undefined

- [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Add deprecation guidance and timeline for Bridge.routes({ sortBy }).

Deprecation notices are more useful with next-steps and a rough removal target. Suggest clarifying default behavior and when removal may occur. Also add a terminal period for consistency.

Proposed tweak:

- - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes
+ - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in `Bridge.routes`.
+   The `sortBy` argument will be removed in a future major release; please remove it from any calls.
+   Routes are returned in the default order provided by the service.

Optional verification script to ensure code is annotated with a deprecation marker:


🏁 Script executed:

#!/bin/bash
# Verify `sortBy` usages and @deprecated annotations
rg -n "Bridge\.routes" -A 10 -B 2
rg -n "sortBy" -A 2 -B 2
rg -n "@deprecated.*sortBy" -A 2 -B 2

Length of output: 60883


Update CHANGELOG.md with deprecation guidance and timeline

The deprecation notice for sortBy in Bridge.routes should include next steps, a removal target, default behavior, and end with a period for consistency.

• File: packages/thirdweb/CHANGELOG.md
Line: 7

- - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes
+ - [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in `Bridge.routes`.
+   The `sortBy` argument will be removed in a future major release; please remove it from any calls.
+   Routes are returned in the default order provided by the service.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in Bridge.routes
- [#7825](https://github.com/thirdweb-dev/js/pull/7825) [`a77e98a`](https://github.com/thirdweb-dev/js/commit/a77e98a48a2f10d8b465e2ef1ba0f28a6df43f3f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Deprecates `sortBy` parameter in `Bridge.routes`.
The `sortBy` argument will be removed in a future major release; please remove it from any calls.
Routes are returned in the default order provided by the service.
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md around line 7, the deprecation note for
`sortBy` in Bridge.routes is missing guidance and punctuation; update that line
to: add a short "Next steps" paragraph advising users how to migrate (e.g., use
the new param or omit), state the removal target (version or date) and the
default behavior after removal, and ensure the sentence ends with a period for
consistency.


- [#7817](https://github.com/thirdweb-dev/js/pull/7817) [`66c7df9`](https://github.com/thirdweb-dev/js/commit/66c7df98e42dc7b5168b817e3f9a179349479d62) Thanks [@0xFirekeeper](https://github.com/0xFirekeeper)! - Adds TikTok as a new authentication method for In-App and Ecosystem Wallets.

- [#7827](https://github.com/thirdweb-dev/js/pull/7827) [`90f36bc`](https://github.com/thirdweb-dev/js/commit/90f36bc414a8f29b9794d3d6a15e2b3e145eca7c) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Hide quote value in payment widgets

## 5.105.31

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -409,5 +409,5 @@
}
},
"typings": "./dist/types/exports/thirdweb.d.ts",
"version": "5.105.31"
"version": "5.105.32"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Patch release version updated

Set to 5.105.32, matching the new changelog entry. LGTM.

To ensure the deprecation of Bridge.routes sortBy is fully reflected, you can scan for remaining references and update JSDoc/types as needed:


🏁 Script executed:

#!/bin/bash
# Search for Bridge.routes and any 'sortBy' usage across the repo
rg -n --no-ignore -S $'Bridge\\.routes\\(|sortBy' | sed 's/^/~/'
# Optionally, list TS definitions mentioning sortBy
rg -n --no-ignore -S $'sortBy' --glob '*.ts' --glob '*.d.ts'

Length of output: 12766


Ensure complete deprecation of the Bridge.routes sortBy option

Although the version was bumped to 5.105.32, references to options.sortBy remain throughout the codebase. Please update all JSDoc, types, implementation, hooks, and tests to either remove or mark this parameter as deprecated—and, if desired, emit a runtime warning when it’s used.

• packages/thirdweb/src/bridge/Routes.ts
– Add @deprecated to @param options.sortBy in the JSDoc
– Mark or remove the sortBy?: "popularity"; field in the BridgeRoutesOptions type (around line 210)
– Deprecate or remove the if (sortBy) url.searchParams.set("sortBy", sortBy); block (around lines 160–161)

• packages/thirdweb/src/react/core/hooks/useBridgeRoutes.ts (+ its test)
– Stop passing sortBy through to Bridge.routes (or mark it deprecated)
– Update the test in useBridgeRoutes.test.ts to reflect removal/deprecation

• apps/dashboard/src/(app)/(dashboard)/(bridge)/utils.ts
– Remove or deprecate any hard-coded sortBy values on Bridge route utils

🤖 Prompt for AI Agents
In packages/thirdweb/package.json at line 412 and associated files
(packages/thirdweb/src/bridge/Routes.ts around lines ~160 and ~210,
packages/thirdweb/src/react/core/hooks/useBridgeRoutes.ts and its test
useBridgeRoutes.test.ts, and
apps/dashboard/src/(app)/(dashboard)/(bridge)/utils.ts), remove or mark the
Bridge.routes options.sortBy as deprecated: add @deprecated to the @param
options.sortBy JSDoc in Routes.ts, update the BridgeRoutesOptions type to either
remove the sortBy?: "popularity" field or mark it deprecated in the type
comment, remove or deprecate the runtime block that sets
url.searchParams.set("sortBy", sortBy) (around lines 160–161) or replace it with
a runtime console.warn if you choose to keep backward compatibility, stop
passing sortBy from useBridgeRoutes and update its test to reflect the change
(remove assertions expecting sortBy to be forwarded or assert a deprecation
warning), and remove or deprecate any hard-coded sortBy usages in the dashboard
bridge utils, ensuring tests and types are adjusted accordingly.

}
2 changes: 2 additions & 0 deletions packages/wagmi-adapter/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# @thirdweb-dev/wagmi-adapter

## 0.2.129

## 0.2.128

## 0.2.127
Expand Down
2 changes: 1 addition & 1 deletion packages/wagmi-adapter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,5 @@
"type": "module",
"types": "./dist/types/exports/thirdweb.d.ts",
"typings": "./dist/types/exports/thirdweb.d.ts",
"version": "0.2.128"
"version": "0.2.129"
}
Loading