Skip to content

Don't let codecov fail build with "No report found to compare against" #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't let codecov fail build with "No report found to compare against" #2189

wants to merge 1 commit into from

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Jul 3, 2017

From here: https://github.com/codecov/support/issues/173#issuecomment-216067683

This might help with codecov failing to find a report for the base commit. Let's find out ...

@jennybc
Copy link
Member Author

jennybc commented Jul 3, 2017

It looks like this has been an ongoing problem that is, in theory, fixed, but in reality maybe not, based on all the +1's here: https://github.com/codecov/support/issues/363#issuecomment-292604547

So it might be reasonable to simply not allow codecov to fail a build for this reason. Which is the intent of this PR.

@karawoo
Copy link
Member

karawoo commented Jul 3, 2017

@hadley shall we give this a try? It seems to have (retroactively??) fixed the codecov issue in #2179. I guess the other option is "just pray codecov sorts itself out" -- my last PR (#2190) didn't have any problems.

@karawoo karawoo requested a review from hadley July 3, 2017 21:56
@jennybc
Copy link
Member Author

jennybc commented Jul 3, 2017

It seems like you got your codecov failures for inexplicable and self-resolving reasons. Which I have also experienced. I'd err on the side of not doing anything rash unless the problem persists.

It would be different if codecov was failing builds due to picky reasons about coverage percentage. I would take control of that in the yaml. But this "no report" error is a different problem.

@hadley
Copy link
Member

hadley commented Jul 5, 2017

Ok, let's leave for now, and if we don't see any more problems we can close this PR.

@hadley hadley closed this Jul 13, 2017
@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants