Skip to content

Update sf graticule label tests that will fail when the next sf version is released #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Update sf graticule label tests that will fail when the next sf version is released #3378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 33 additions & 17 deletions tests/testthat/test-coord_sf.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test_that("graticule lines can be removed via theme", {
expect_doppelganger("no panel grid", plot)
})

test_that("axis labels can be set manually", {
test_that("axis labels are correct for manual breaks", {
skip_if_not_installed("sf")

plot <- ggplot(sf::st_polygon(list(matrix(1e3*c(1, 2, 3, 1, 1, 3, 2, 1), ncol = 2)))) +
Expand All @@ -53,6 +53,13 @@ test_that("axis labels can be set manually", {
graticule[graticule$type == "N", ]$degree_label,
c("1000", "1500", "2000")
)
})

test_that("axis labels can be set manually", {
skip_if_not_installed("sf")

plot <- ggplot(sf::st_polygon(list(matrix(1e3*c(1, 2, 3, 1, 1, 3, 2, 1), ncol = 2)))) +
geom_sf()

# character labels
b <- ggplot_build(
Expand All @@ -75,9 +82,14 @@ test_that("axis labels can be set manually", {
graticule[graticule$type == "N", ]$degree_label,
c("D", "E", "F")
)
})

test_that("factors are treated like character labels and are not parsed", {
skip_if_not_installed("sf")

plot <- ggplot(sf::st_polygon(list(matrix(1e3*c(1, 2, 3, 1, 1, 3, 2, 1), ncol = 2)))) +
geom_sf()

# factors are treated like character labels
# and are not parsed
b <- ggplot_build(
plot +
scale_x_continuous(
Expand All @@ -98,9 +110,14 @@ test_that("axis labels can be set manually", {
graticule[graticule$type == "N", ]$degree_label,
c("1 * degree * N", "1.5 * degree * N", "2 * degree * N")
)
})

test_that("expressions can be mixed with character labels", {
skip_if_not_installed("sf")

plot <- ggplot(sf::st_polygon(list(matrix(1e3*c(1, 2, 3, 1, 1, 3, 2, 1), ncol = 2)))) +
geom_sf()

# expressions mixed with character labels
b <- ggplot_build(
plot +
scale_x_continuous(
Expand Down Expand Up @@ -147,33 +164,32 @@ test_that("axis labels can be set manually", {
graticule[graticule$type == "E", ]$degree_label,
parsed
)
})

test_that("degree labels are automatically parsed", {
skip_if_not_installed("sf")

# autoparsing of degree labels
data <- sf::st_sfc(
sf::st_polygon(list(matrix(1e1*c(1, 2, 3, 1, 1, 3, 2, 1), ncol = 2))),
crs = 4326 # basic long-lat crs
)

plot <- ggplot(data) + geom_sf()

b <- ggplot_build(
plot +
scale_x_continuous(breaks = c(10, 20, 30)) +
scale_y_continuous(breaks = c(10, 15, 20))
)

graticule <- b$layout$panel_params[[1]]$graticule
parsed <- vector("list", 3)
parsed[1:3] <- parse(text = c("10*degree*E", "20*degree*E", "30*degree*E"))
expect_identical(
graticule[graticule$type == "E", ]$degree_label,
parsed
expect_setequal(
graticule[graticule$type == "N", ]$degree,
c(10, 15, 20)
)
parsed[1:3] <- parse(text = c("10*degree*N", "15*degree*N", "20*degree*N"))
expect_identical(
graticule[graticule$type == "N", ]$degree_label,
parsed
expect_setequal(
graticule[graticule$type == "E", ]$degree,
c(10, 20, 30)
)

expect_true(all(vapply(graticule$degree_label, is.language, logical(1))))
})

test_that("Inf is squished to range", {
Expand Down