-
Notifications
You must be signed in to change notification settings - Fork 2.1k
README Typo, Capitalization Changes #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Typo: "the the" to "the" in installation instructions Changes Capitalization of Book and Chapter names: Data Visualisation chapter ref (anchor only) Graphics for communication (anchor only, matches actual) R for Data Science book name (anchor and text usage)
To update |
Ah. |
side effect: modified: man/figures/README-example-1.png
ok. Managed to get that to work via RStudio, but there was a side effect: A png file was re-created (git diff says these files are different). I suspect this was expected, so I left it in the commit. |
The new png is much smaller than the old one. @yutannihilation Any idea why by any chance? Did the default format change? |
One more request, while you're at it: Could you change the URLs to https where they exist (probably all of them)? |
Not sure what causes the change (Pandoc 2 become smarter to resize the image to the necessary size?), but it seems reproducible. So, I think it's OK to merge. Confession: I cheated on #3632 by editing |
okay - updated those specs to be https. while testing the links, noticed many were converting to https at the site anyway (they were all updated in the README, regardless). the png file did not re-gen upon this knitting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Found this while looking to contribute for another Documentation item.
Did not find an open issue for any of these items in the README file.
git log entry:
Notes
Looked at a couple of other
README.Rmd
PRs.Did not see changes to
README.md
in the PR, so making assumption that's somehow automated and out-of-scope for a README PR.If needed here, will need instructions of generating an updated
README.md
from the.Rmd
file.