Add tests to the compiler package #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make exported names a bit more consistent. I believe there was a bug report for this issue, but I can't easily find it. In any case, I think it's an important improvement to match the behavior of the Go toolchain.
aykevl
force-pushed
the
compiler-tests-2
branch
from
9dc1b78 to
a485c18
Compare
This commit finally introduces unit tests for the compiler, to check whether input Go code is converted to the expected output IR. To make this necessary, a few refactors were needed. Hopefully these refactors (to compile a program package by package instead of all at once) will eventually become standard, so that packages can all be compiled separate from each other and be cached between compiles.
aykevl
force-pushed
the
compiler-tests-2
branch
from
a485c18 to
1c5d9bd
Compare
niaow
approved these changes
Jan 15, 2021
aykevl
added a commit
that referenced
this pull request
Jan 24, 2021
Since #1571 (in particular, the first commit that sets the main package path), the main package is always named "main". This makes the callMain() workaround in the runtime unnecessary and allows directly calling the main.main function with a //go:linkname pragma.
deadprogram
pushed a commit
that referenced
this pull request
Jan 24, 2021
Since #1571 (in particular, the first commit that sets the main package path), the main package is always named "main". This makes the callMain() workaround in the runtime unnecessary and allows directly calling the main.main function with a //go:linkname pragma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my next attempt to make the compiler more modular (also see #1008). This time I managed to add tests to the compiler without too many complications.
Testing is still quite limited as it isn't yet possible to test anything that refers to runtime types or functions, which are the most interesting tests.
I did this in #1008but left it out in this PR to keep things simple and focused. I intend to introduce runtime types in a later PR and with that change, add more compiler tests.The first commit of this PR is a small change that renames the main package in the IR. This could have real world impact but I think it is an improvement as output binaries now better match the symbol name conventions of the Go toolchain.
Updates #285.