compiler: remove unnecessary main.main call workaround #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #1571 (in particular, the first commit that sets the main package path), the main package is always named "main". This makes the callMain() workaround in the runtime unnecessary and allows directly calling the main.main function with a //go:linkname pragma.
|
Nice ✂️ merging. |
aykevl
added a commit
to tinygo-org/drivers
that referenced
this pull request
Jan 27, 2021
The package with the main function should always have the name main. This was not the case in three packages. This was silently allowed before, but since a TinyGo change (tinygo-org/tinygo#1592) this now results in a linker failure. Perhaps this should result in a better error message in TinyGo. However, the example code also needs to be fixed, so hence this PR.
deadprogram
pushed a commit
to tinygo-org/drivers
that referenced
this pull request
Jan 27, 2021
The package with the main function should always have the name main. This was not the case in three packages. This was silently allowed before, but since a TinyGo change (tinygo-org/tinygo#1592) this now results in a linker failure. Perhaps this should result in a better error message in TinyGo. However, the example code also needs to be fixed, so hence this PR.
ardnew
pushed a commit
to ardnew/drivers
that referenced
this pull request
Feb 14, 2021
The package with the main function should always have the name main. This was not the case in three packages. This was silently allowed before, but since a TinyGo change (tinygo-org/tinygo#1592) this now results in a linker failure. Perhaps this should result in a better error message in TinyGo. However, the example code also needs to be fixed, so hence this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1571 (in particular, the first
commit that sets the main package path), the main package is always named
"main". This makes the callMain() workaround in the runtime unnecessary and
allows directly calling the main.main function with a //go:linkname pragma.
This is just a small refactor to clean up the code a bit.