Hashmap improvements #347
Merged
Hashmap improvements #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving all allocas used in hashmap operations to the entry block, the stack frame remains at a fixed size known at compile time. This avoids stack overflows when doing map operations in loops and in general improves code quality: the compiled size of testdata/map.go went from 3776 to 3632 in .text size.
aykevl
force-pushed
the
hashmap-improvements
branch
from
220168a to
5ee7c8c
Compare
aykevl
commented
May 13, 2019
compiler/compiler.go
Outdated
| var err error | ||
| sizeHint, err = c.parseConvert(expr.Reserve.Type(), types.Typ[types.Uintptr], sizeHint, expr.Pos()) | ||
| if err != nil { | ||
| return llvm.Value{}, nil |
It defaults to hint/8 number of buckets. This number may be tuned in the future.
Add support for growing hashmaps beyond their initial size.
aykevl
force-pushed
the
hashmap-improvements
branch
from
5ee7c8c to
8b2ae84
Compare
|
Also fixed a leftover from #294 in the last commit (no functional change). Unrelated, but I thought I'd add it here as it is really trivial. |
aykevl
force-pushed
the
hashmap-improvements
branch
from
08feb41 to
48a3aca
Compare
No error is produced, so no error needs to be returned. It was missed in #294. Also, it fixes this smelly code: if err != nil { return <something>, nil } There could never be an error, so the code was already dead.
aykevl
force-pushed
the
hashmap-improvements
branch
from
48a3aca to
2c2f6b7
Compare
|
OK, great, we need this. Now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement growing of hashmaps and setting the initial size. Necessary for
js.Funcsupport (#226), among others.