compiler: refactor globals and named types #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors named types to be created lazily. Instead of defining all types in advance, do it only when necessary.
This is part of a larger rafactor that tries to shrink the ir package and in general tries to shrink the amount of state that is kept around in the compiler. The end goal is being able to compile packages independent of each other, linking them together in a later stage. Along the way, it cleans up lots of old cruft that has accumulated over the months. This refactor also results in globals being loaded lazily. This may be a problem for some specific programs but will probably change back in a commit in the near future.
deadprogram
reviewed
Jun 8, 2019
|
|
||
| // loadASTComments loads comments on globals from the AST, for use later in the | ||
| // program. In particular, they are required for //go:extern pragmas on globals. | ||
| func (c *Compiler) loadASTComments(lprogram *loader.Program) { |
There was a problem hiding this comment.
OMG this function... yes I know it is just in a new location, but this just brings it to our collective attention. 😸
There was a problem hiding this comment.
Yeah I know but it's the only way to support pragmas on globals. I would really like to get rid of it as it's rather dirty.
|
Now merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get rid of the
irpackage, that is not necessary anymore and has been holding back other refactors (in particular, #285).There is more to come, but refactoring functions in the same way has far more side effects so needs some more fixes (like #399).