-
Notifications
You must be signed in to change notification settings - Fork 958
compiler: refactor globals and named types #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+166
−176
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| package compiler | ||
|
|
||
| // This file manages symbols, that is, functions and globals. It reads their | ||
| // pragmas, determines the link name, etc. | ||
|
|
||
| import ( | ||
| "go/ast" | ||
| "go/token" | ||
| "go/types" | ||
| "strings" | ||
|
|
||
| "github.com/tinygo-org/tinygo/loader" | ||
| "golang.org/x/tools/go/ssa" | ||
| "tinygo.org/x/go-llvm" | ||
| ) | ||
|
|
||
| // globalInfo contains some information about a specific global. By default, | ||
| // linkName is equal to .RelString(nil) on a global and extern is false, but for | ||
| // some symbols this is different (due to //go:extern for example). | ||
| type globalInfo struct { | ||
| linkName string // go:extern | ||
| extern bool // go:extern | ||
| } | ||
|
|
||
| // loadASTComments loads comments on globals from the AST, for use later in the | ||
| // program. In particular, they are required for //go:extern pragmas on globals. | ||
| func (c *Compiler) loadASTComments(lprogram *loader.Program) { | ||
| c.astComments = map[string]*ast.CommentGroup{} | ||
| for _, pkgInfo := range lprogram.Sorted() { | ||
| for _, file := range pkgInfo.Files { | ||
| for _, decl := range file.Decls { | ||
| switch decl := decl.(type) { | ||
| case *ast.GenDecl: | ||
| switch decl.Tok { | ||
| case token.VAR: | ||
| if len(decl.Specs) != 1 { | ||
| continue | ||
| } | ||
| for _, spec := range decl.Specs { | ||
| switch spec := spec.(type) { | ||
| case *ast.ValueSpec: // decl.Tok == token.VAR | ||
| for _, name := range spec.Names { | ||
| id := pkgInfo.Pkg.Path() + "." + name.Name | ||
| c.astComments[id] = decl.Doc | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // getGlobal returns a LLVM IR global value for a Go SSA global. It is added to | ||
| // the LLVM IR if it has not been added already. | ||
| func (c *Compiler) getGlobal(g *ssa.Global) llvm.Value { | ||
| info := c.getGlobalInfo(g) | ||
| llvmGlobal := c.mod.NamedGlobal(info.linkName) | ||
| if llvmGlobal.IsNil() { | ||
| llvmType := c.getLLVMType(g.Type().(*types.Pointer).Elem()) | ||
| llvmGlobal = llvm.AddGlobal(c.mod, llvmType, info.linkName) | ||
| if !info.extern { | ||
| llvmGlobal.SetInitializer(c.getZeroValue(llvmType)) | ||
| llvmGlobal.SetLinkage(llvm.InternalLinkage) | ||
| } | ||
| } | ||
| return llvmGlobal | ||
| } | ||
|
|
||
| // getGlobalInfo returns some information about a specific global. | ||
| func (c *Compiler) getGlobalInfo(g *ssa.Global) globalInfo { | ||
| info := globalInfo{} | ||
| if strings.HasPrefix(g.Name(), "C.") { | ||
| // Created by CGo: such a name cannot be created by regular C code. | ||
| info.linkName = g.Name()[2:] | ||
| info.extern = true | ||
| } else { | ||
| // Pick the default linkName. | ||
| info.linkName = g.RelString(nil) | ||
| // Check for //go: pragmas, which may change the link name (among | ||
| // others). | ||
| doc := c.astComments[info.linkName] | ||
| if doc != nil { | ||
| info.parsePragmas(doc) | ||
| } | ||
| } | ||
| return info | ||
| } | ||
|
|
||
| // Parse //go: pragma comments from the source. In particular, it parses the | ||
| // //go:extern pragma on globals. | ||
| func (info *globalInfo) parsePragmas(doc *ast.CommentGroup) { | ||
| for _, comment := range doc.List { | ||
| if !strings.HasPrefix(comment.Text, "//go:") { | ||
| continue | ||
| } | ||
| parts := strings.Fields(comment.Text) | ||
| switch parts[0] { | ||
| case "//go:extern": | ||
| info.extern = true | ||
| if len(parts) == 2 { | ||
| info.linkName = parts[1] | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG this function... yes I know it is just in a new location, but this just brings it to our collective attention. 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I know but it's the only way to support pragmas on globals. I would really like to get rid of it as it's rather dirty.