Add support for newer SVD files in cmsis-svd repository #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some newer files have a few mistakes. Allow them to be processed.
Merged
|
📜 thanks for doing this work, I know what a pain it is. Now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a small refactor. I hope that we can move more and more towards such code (that is less procedural).
The second commit fixes some issues with a more recent cmsis-svd repository. Some of the newer stm32 files have a few issues. This commit makes the conversion a bit more forgiving.
These changes have been tested by comparing all older .go files before and after this commit, and there is no difference between them. That means it should not break backwards compatibility.