Resolver bundles creation + bundles for a bunch of resolvers #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo
added a commit
that referenced
this pull request
Mar 24, 2013
Resolver bundles creation + bundles for a bunch of resolvers
theli-ua
pushed a commit
to theli-ua/tomahawk-resolvers
that referenced
this pull request
Aug 31, 2017
…ndles Resolver bundles creation + bundles for a bunch of resolvers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds:
json2desktop.rb, a script that generatesmetadata.desktopfrommetadata.json, to be used by Synchrotron;makeaxe.rb, a script that reads a resolver'smetadata.jsonand creates a compressed bundle (axe);metadata.jsonfiles for several resolvers, along with needed directory structure changes.For more information about the
metadata.jsonformat and the required directory structure, see the comments inmakeaxe.rband theHACKING.mdfile.ATTENTION: since having unlicensed code is a bad thing and JS resolvers are at least derivative works of
tomahawk.js, and possibly also ofQtScriptResolverHelper, I have taken the liberty of adding a GPL v3 header to those resolvers that had no license. I am aware that it's not ideal to add license statements to code done by people who haven't licensed it explicitly, but I think this choice makes sense, since the alternative is a mess at best and possibly a violation. I have also added copyright statements for those few resolvers who had none, based ongit blame.See tomahawk-player/tomahawk#170 for the Tomahawk part of this pull request.