Resolver bundles support #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The good: * you can now add multiple scripts to be loaded for a single resolver before the main script, specified in metadata.json in a bundle. The bad: * it adds some complexity, and it's not tested at all. The ugly: * passing configuration from ResolverAccountFactory as QVariantHash, but that's not new, * changing ResolverFactoryFunc, * an added optional QStringList parameter to Pipeline::addScriptResolver, * the inevitable uselessness of this parameter in ScriptResolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A resolver bundle is a directory, which may or may not be compressed into an archive, that contains all the files that belong to a resolver plus metadata.
This pull request adds support for installing (and removing) resolver bundles, both compressed and uncompressed. It also allows Tomahawk to display some metadata about a non-Attica resolver, and load additional scripts before the main script.
Please take special care when reviewing commit 4d2a942, I'm not very happy about how it passes around the additional script paths but haven't found a better solution.
See tomahawk-player/tomahawk-resolvers#38 for the resolvers part of this pull request.