Examples rework and viewer #696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- markersDirectiveSpecs switched to coffee
breaking up leafletEvents for developers sake
- safeApply boilerplate wrapped with leafletEventsHelper.fire Events now pass layerName if it exists and it passes the model.
markersControl setup to be fetched from leafletData.directivesControls markers control and markersWatchOptions working, tests broken markers control and markersWatchOptions working, tests broken save off on markersWatchOptions specs fixed example
- Making the directiveControls logic more modular along with watchOptions directives.
- on creation copy the model so changes to lObjects do not affect the model/trigger scope digest - model differences working now where copy in _addMarker is very important
- nested geojson specs
- markersDirectiveSpecs switched to coffee
breaking up leafletEvents for developers sake
- safeApply boilerplate wrapped with leafletEventsHelper.fire Events now pass layerName if it exists and it passes the model.
markersControl setup to be fetched from leafletData.directivesControls markers control and markersWatchOptions working, tests broken markers control and markersWatchOptions working, tests broken save off on markersWatchOptions specs fixed example
|
Is it possible to rebase? This is massive. I trust you and it is mainly examples anyways. But the github reviewer is throwing up and slow; so this is hard to digest. |
|
Mmm... I'm recreating this PR again, it has messed up a little with all the commits these days |
|
If rebase is too difficult just merge the latest changes in. I need to work on a possible bug for leafletData |
|
k |
|
btw we should proabably add |
|
I'll push up build fix immediately. |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I finally finished this work. It has been intense.
This is a rework of all the examples added in the "examples" directory, with two main changes.
This is accomplished by following a standard creating the HTML examples, and by a NodeJS script.
When adding a new example , or modifying an existing one, you can add it to the viewer executing:
There are a few examples wich doesn't work now, and that's because there has been a lot of changes lastly on the library, I will fix them (or fix the library bug if present) in the meantime.
The protractor tests needs to be modified too, but that will be another PR.
You can see the work explained here in this "example-browser":
http://tombatossals.github.io/angular-leaflet-directive/examples/0000-viewer.html