New examples rework & Viewer #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
nmccready
added a commit
that referenced
this pull request
Apr 17, 2015
New examples rework & Viewer
wking
added a commit
to wking/angular-leaflet-directive
that referenced
this pull request
Jun 27, 2016
For example, the markers-angular-template-example.html was stale because: * eaa051c (Removed old examples, 2015-04-17, tombatossals#697) removed the unprefixed version. * 2c40797 (new versions of examples, 2015-04-17, tombatossals#697) added an 0514 prefix. * 726d37c (fix(examples) Fix ESRI legend examples, 2015-09-18, tombatossals#949) changed the prefix to 0515. The only example that did not retain its name across the eaa051c / 2c40797 transition was markers-update-example.html. I'm assuming that the new version of that example is 0504-markers-popup-example.html, because it is the only new example HTML which contains leafletDirectiveMarker.popupopen. This commit just updates the links. I have not checked the surrounding text to see if it is also stale.
wking
added a commit
to wking/angular-leaflet-directive
that referenced
this pull request
Jun 27, 2016
For example, the markers-angular-template-example.html link was stale because: * eaa051c (Removed old examples, 2015-04-17, tombatossals#697) removed the unprefixed version. * 2c40797 (new versions of examples, 2015-04-17, tombatossals#697) added an 0514 prefix. * 726d37c (fix(examples) Fix ESRI legend examples, 2015-09-18, tombatossals#949) changed the prefix to 0515. The only example that did not retain its name across the eaa051c / 2c40797 transition was markers-update-example.html. I'm assuming that the new version of that example is 0504-markers-popup-example.html, because it is the only new example HTML which contains leafletDirectiveMarker.popupopen. This commit just updates the links. I have not checked the surrounding text to see if it is also stale.
wking
added a commit
to wking/angular-leaflet-directive
that referenced
this pull request
Jun 27, 2016
For example, the markers-angular-template-example.html link was stale because: * eaa051c (Removed old examples, 2015-04-17, tombatossals#697) removed the unprefixed version. * 2c40797 (new versions of examples, 2015-04-17, tombatossals#697) added an 0514 prefix. * 726d37c (fix(examples) Fix ESRI legend examples, 2015-09-18, tombatossals#949) changed the prefix to 0515. The only example that did not retain its name across the eaa051c / 2c40797 transition was markers-update-example.html. I'm assuming that the new version of that example is 0504-markers-popup-example.html, because it is the only new example HTML which contains leafletDirectiveMarker.popupopen. This commit just updates the links. I have not checked the surrounding text to see if it is also stale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added again this branch, commented here:
#696