[PROD] - Copilot Portal Fixes & Updates #1158

kkartunov · 2025-07-28T06:54:28Z

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-1522
https://topcoder.atlassian.net/browse/PM-1291

What's in this PR?

PM-732 - Update build script: remove "build" dir before creating a new build

Add status message for no Applications

PM-1315 Fix issues on Copilot request form

fix(PM-1320): Layout issues in copilot opportunity details page

fix(PM-1323, PM-1324): UI issues in opportunities and requests list

PM-1321 Fix alignment issues on copilot form

…tunity-title PM-1498 - support for opportunity title

fix(PM-1395): Show apply as copilot button for a user who is both admin and copilot

fix(PM-1397): notes column

PM-1384 Fix date picker in copilot form

…request PM-1499 edit copilot request

PM-1531 Fix: Trim form values before submit

github-actions · 2025-07-31T02:53:13Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

@@ -141,7 +190,7 @@ const CopilotRequestForm: FC<{}> = () => {
            { condition: !formValues.paymentType, key: 'paymentType', message: 'Selection is required' },
            { condition: !formValues.projectType, key: 'projectType', message: 'Selecting project type is required' },
            {
-                condition: !formValues.overview || formValues.overview.length < 10,
+                condition: !formValues.overview || formValues.overview.trim().length < 10,


Consider checking if formValues.overview is a string before using trim() to avoid potential runtime errors if overview is not a string.

github-actions · 2025-07-31T02:53:16Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

@@ -171,7 +220,7 @@ const CopilotRequestForm: FC<{}> = () => {
                message: 'Number of weeks should be a positive number',
            },
            {
-                condition: !formValues.tzRestrictions,
+                condition: !formValues.tzRestrictions || formValues.tzRestrictions.trim().length === 0,


The condition formValues.tzRestrictions.trim().length === 0 assumes that formValues.tzRestrictions is always a string. Consider adding a check to ensure formValues.tzRestrictions is indeed a string before calling trim() to avoid potential runtime errors if it is null or undefined.

github-actions · 2025-07-31T02:53:18Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

@@ -185,6 +234,11 @@ const CopilotRequestForm: FC<{}> = () => {
                key: 'numHoursPerWeek',
                message: 'Number of hours per week should be a positive number',
            },
+            {
+                condition: formValues.otherPaymentType && formValues.otherPaymentType.trim().length === 0,


Consider checking if formValues.otherPaymentType is defined before calling trim() to avoid potential runtime errors if otherPaymentType is null or undefined.

fix(PM-1510): Fixed copy for the already user modal

github-actions · 2025-07-31T06:10:26Z

...ilots/src/pages/copilot-opportunity-details/tabs/copilot-applications/AlreadyMemberModal.tsx

+                  project with ${props.copilotApplication.existingMembership?.role} role.`}
+
+                {
+                    props.copilotApplication.existingMembership


Consider using a more descriptive variable name for props.copilotApplication.existingMembership to improve readability.

github-actions · 2025-07-31T06:10:27Z

...ilots/src/pages/copilot-opportunity-details/tabs/copilot-applications/AlreadyMemberModal.tsx

+
+                {
+                    props.copilotApplication.existingMembership
+                  && ['copilot', 'manager'].includes(props.copilotApplication.existingMembership.role)


The logic here checks for specific roles. Ensure that the roles are correctly defined and consistent with the application's role management system.

github-actions · 2025-07-31T06:10:27Z

...ilots/src/pages/copilot-opportunity-details/tabs/copilot-applications/AlreadyMemberModal.tsx

+                }
+
+                {
+                    props.copilotApplication.existingMembership


The logic here checks for specific roles. Ensure that the roles are correctly defined and consistent with the application's role management system.

github-actions · 2025-07-31T06:10:27Z

...ilots/src/pages/copilot-opportunity-details/tabs/copilot-applications/AlreadyMemberModal.tsx

+                  && ['observer', 'customer'].includes(props.copilotApplication.existingMembership.role)
+                  && (
+                      <div>
+                          Click &apos;Confirm&apos; to accept by updating project role to &apos;Copilot&apos;


Consider rephrasing the message for clarity. For example, 'Click 'Confirm' to update the project role to 'Copilot' and complete this opportunity.'

PM-1532 Fix sorting on title

fix(PM-1506): Show modal text based on existing role

github-actions · 2025-07-31T13:57:33Z

...ilots/src/pages/copilot-opportunity-details/tabs/copilot-applications/AlreadyMemberModal.tsx

+
+                {
+                    props.copilotApplication.existingMembership
+                  && ['observer', 'customer'].includes(props.copilotApplication.existingMembership.role)


The roles in the condition have been swapped. Ensure that this change is intentional and aligns with the business logic requirements.

github-actions · 2025-07-31T13:57:33Z

...ilots/src/pages/copilot-opportunity-details/tabs/copilot-applications/AlreadyMemberModal.tsx

+
+                {
+                    props.copilotApplication.existingMembership
+                  && ['copilot', 'manager'].includes(props.copilotApplication.existingMembership.role)


The roles in the condition have been swapped. Verify that this change is correct and meets the intended functionality.

fix(PM-1506): revert back to old code

PM-1518 Fix 429 too many requests error

github-actions · 2025-08-01T06:57:07Z

src/apps/copilots/src/services/projects.ts

@@ -11,6 +11,8 @@ const baseUrl = `${EnvironmentConfig.API.V5}/projects`

 export type ProjectsResponse = SWRResponse<Project[], Project[]>

+const sleep = (ms: number): Promise<()=> void> => new Promise(resolve => { setTimeout(resolve, ms) })


The sleep function is defined but not used anywhere in the code. Consider removing it if it's not needed, or ensure it's utilized appropriately within the codebase.

github-actions · 2025-08-01T06:57:10Z

src/apps/copilots/src/services/projects.ts

+            const allResults: Project[] = []
+
+            for (const chunkIds of idChunks) {
+                // eslint-disable-next-line no-await-in-loop


Using await inside a loop can lead to performance issues due to sequential execution. Consider refactoring to use Promise.all for concurrent execution if possible, while still respecting rate limits.

github-actions · 2025-08-01T06:57:10Z

src/apps/copilots/src/services/projects.ts

+
+                // Rate limit: delay 200ms between calls
+                // eslint-disable-next-line no-await-in-loop
+                await sleep(200)


The use of sleep(200) for rate limiting is not ideal as it can block the event loop. Consider using a more efficient rate limiting strategy, such as a queue or a library designed for rate limiting.

PM-1555 Remove sorting from Payment column

Remove dropdown icon if not more than one in list

github-actions · 2025-08-01T08:06:30Z

src/libs/ui/lib/components/tabs-navbar/TabsNavbar.tsx

@@ -125,7 +125,7 @@ const TabsNavbar: FC<TabsNavbarProps> = (props: TabsNavbarProps) => {
                    handleActivateTab={handleActivateTab}
                    handleActivateChildTab={handleActivateChildTab}
                />
-                <IconOutline.ChevronDownIcon />
+                {props.tabs.length > 1 && <IconOutline.ChevronDownIcon />}


Consider checking if props.tabs is defined before accessing its length property to avoid potential runtime errors if tabs is undefined.

feat(PM-1365): Populate project field in copilot request form when query param presents

github-actions · 2025-08-01T19:46:15Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

 // eslint-disable-next-line
 const CopilotRequestForm: FC<{}> = () => {
    const { profile }: ProfileContextData = useContext(profileContext)
    const navigate = useNavigate()
+    const routeParams: Params<string> = useParams()
+    const [params] = useSearchParams()


Consider using a more descriptive name for the params variable to improve code readability, especially since it is related to search parameters.

github-actions · 2025-08-01T19:46:15Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

 // eslint-disable-next-line
 const CopilotRequestForm: FC<{}> = () => {
    const { profile }: ProfileContextData = useContext(profileContext)
    const navigate = useNavigate()
+    const routeParams: Params<string> = useParams()
+    const [params] = useSearchParams()

    const [formValues, setFormValues] = useState<any>({})


Avoid using any type for formValues. Consider defining a specific type or interface for the form data to ensure type safety.

github-actions · 2025-08-01T19:46:15Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

 // eslint-disable-next-line
 const CopilotRequestForm: FC<{}> = () => {
    const { profile }: ProfileContextData = useContext(profileContext)
    const navigate = useNavigate()
+    const routeParams: Params<string> = useParams()
+    const [params] = useSearchParams()

    const [formValues, setFormValues] = useState<any>({})
    const [isFormChanged, setIsFormChanged] = useState(false)
    const [formErrors, setFormErrors] = useState<any>({})


Avoid using any type for formErrors. Consider defining a specific type or interface for the form errors to ensure type safety.

github-actions · 2025-08-01T19:46:18Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+
+        const project = await getProject(projectId as string)
+
+        setFormValues((prevValues: any) => ({


Consider adding error handling for the getProject function call to manage potential API errors or network issues.

github-actions · 2025-08-01T19:46:18Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+
+        setFormValues((prevValues: any) => ({
+            ...prevValues,
+            projectId: project.id,


The projectId is being set directly from the project object. Ensure that project is not null or undefined before accessing project.id to avoid potential runtime errors.

github-actions · 2025-08-01T19:46:19Z

src/apps/copilots/src/pages/copilot-request-form/index.tsx

+        }))
+
+        return projectFromQuery
+            ? [...projectsFromResponse, { label: projectFromQuery.name, value: projectFromQuery.id }]


Check for duplicate project entries when adding projectFromQuery to projectsFromResponse to prevent redundant options in the dropdown.

github-actions · 2025-08-01T19:46:21Z

src/apps/copilots/src/services/projects.ts

@@ -43,6 +58,11 @@ export const useProjects = (search?: string, config?: {isPaused?: () => boolean,
    })
 }

+export const getProject = (projectId: string): Promise<Project> => {


Consider adding error handling to the getProject function to manage potential failures from the xhrGetAsync call.

github-actions · 2025-08-01T19:46:21Z

src/apps/copilots/src/services/projects.ts

+    const url = `${baseUrl}/${projectId}`
+    return xhrGetAsync<Project>(url)
+}
+
 export const getProjects = (search?: string, filter?: any): Promise<Project[]> => {


The filter parameter is typed as any. Consider using a more specific type to improve type safety and maintainability.

vas3a and others added 30 commits July 15, 2025 08:49

Update build script: remove "build" dir before creating a new build

57a6076

Merge pull request #1138 from topcoder-platform/PM-732_build-update

bc1f9b4

PM-732 - Update build script: remove "build" dir before creating a new build

Add status message for no Applications

4326b8d

linting fixes

f9328c1

fix: layout issues in mobile resolution

f8efdd2

fix: layout issues in mobile resolution

cc980c6

fix: layout issues in mobile resolution

8d519f4

PM-1315 Fix issues on Copilot request form

8968136

fix: UI issues in opportunities and requests list

42fc635

Merge pull request #1139 from topcoder-platform/PM-1269

530a90a

Add status message for no Applications

Merge pull request #1141 from topcoder-platform/PM-1315

077ba3b

PM-1315 Fix issues on Copilot request form

Merge pull request #1140 from topcoder-platform/pm-1320

281e47d

fix(PM-1320): Layout issues in copilot opportunity details page

Merge pull request #1142 from topcoder-platform/pm-1323

7d06d63

fix(PM-1323, PM-1324): UI issues in opportunities and requests list

PM-1321 Fix alignment issues on copilot form

2b67683

Merge pull request #1143 from topcoder-platform/PM-1321

d505fbb

PM-1321 Fix alignment issues on copilot form

PM-1384 Fix date picker in copilot form

9eb0db8

fix: show apply as copilot button for user who is both copilot and admin

472569b

fix: lint

b9353f0

fix: notes column

e6bb39b

PM-1498 - support for opportunity title

e7deb62

typo

596ca36

fix linting error

8184aab

PM-1499 - allow pms and admins to edit copilot requests

b784334

Merge pull request #1147 from topcoder-platform/PM-1498_copilot-oppor…

4519c74

…tunity-title PM-1498 - support for opportunity title

Merge pull request #1145 from topcoder-platform/pm-1395

2ead2c1

fix(PM-1395): Show apply as copilot button for a user who is both admin and copilot

Merge pull request #1146 from topcoder-platform/pm-1397

cfc2d1e

fix(PM-1397): notes column

Merge pull request #1144 from topcoder-platform/PM-1384

8bb8aba

PM-1384 Fix date picker in copilot form

Merge pull request #1148 from topcoder-platform/PM-1499_edit-copilot-…

ea3a141

…request PM-1499 edit copilot request

Update validation for copilot opportunity title

11dc023

length

c781613

Merge pull request #1164 from topcoder-platform/PM-1531

94afdd5

PM-1531 Fix: Trim form values before submit

github-actions bot reviewed Jul 31, 2025

View reviewed changes

hentrymartin added 3 commits July 31, 2025 07:57

fix: qa feedbacks

fbe6eff

fix: lint

82c5f6a

Merge pull request #1166 from topcoder-platform/pm-1510

4c33ab2

fix(PM-1510): Fixed copy for the already user modal

github-actions bot reviewed Jul 31, 2025

View reviewed changes

himaniraghav3 and others added 4 commits July 31, 2025 18:07

PM-1532 Fix sorting on title

ba2fa07

Merge pull request #1167 from topcoder-platform/PM-1532

61e08d4

PM-1532 Fix sorting on title

fix: lint

c999669

Merge pull request #1168 from topcoder-platform/pm-1506_2

dc4d07c

fix(PM-1506): Show modal text based on existing role

github-actions bot reviewed Jul 31, 2025

View reviewed changes

hentrymartin and others added 4 commits July 31, 2025 16:12

fix: revert back to old code

536bbdc

Merge pull request #1169 from topcoder-platform/pm-1506_2

75c5608

fix(PM-1506): revert back to old code

PM-1518 Fix 429 too many requests error

2383f98

Merge pull request #1170 from topcoder-platform/PM-1518

b62d5c7

PM-1518 Fix 429 too many requests error

github-actions bot reviewed Aug 1, 2025

View reviewed changes

himaniraghav3 and others added 4 commits August 1, 2025 12:32

PM-1555 Remove sorting from Payment column

f26509e

Merge pull request #1171 from topcoder-platform/PM-1555

984aada

PM-1555 Remove sorting from Payment column

Remove dropdown icon if not more than one in list

3a9b115

Merge pull request #1172 from topcoder-platform/PM-1529

c58c4e9

Remove dropdown icon if not more than one in list

github-actions bot reviewed Aug 1, 2025

View reviewed changes

hentrymartin added 3 commits August 1, 2025 21:19

feat

5b0abec

fix: circle ci config updates

4da8cb0

Merge pull request #1173 from topcoder-platform/pm-1365_1

ef6d0cd

feat(PM-1365): Populate project field in copilot request form when query param presents

github-actions bot reviewed Aug 1, 2025

View reviewed changes

		@@ -11,6 +11,8 @@ const baseUrl = `${EnvironmentConfig.API.V5}/projects`

		export type ProjectsResponse = SWRResponse<Project[], Project[]>

		const sleep = (ms: number): Promise<()=> void> => new Promise(resolve => { setTimeout(resolve, ms) })


		const project = await getProject(projectId as string)

		setFormValues((prevValues: any) => ({

[PROD] - Copilot Portal Fixes & Updates #1158

Are you sure you want to change the base?

[PROD] - Copilot Portal Fixes & Updates #1158

Uh oh!

Conversation

kkartunov commented Jul 28, 2025

Related JIRA Ticket:

What's in this PR?

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!