Improve types for CheckMessage subclasses #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks a lot for your PRs. |
|
Aye... I had a crack at running the tests locally to try fix that but it felt rather unclear to me :( Might need a git bisect on mypy? |
|
I am pretty sure it is python/mypy#11143 |
adamchainz
force-pushed
the
check_subclasses
branch
from
7e4f012 to
9b7bc72
Compare
sobolevn
approved these changes
Aug 26, 2022
| @@ -19,16 +19,16 @@ class CheckMessage: | |||
| def is_silenced(self) -> bool: ... | |||
|
|
|||
| class Debug(CheckMessage): | |||
| def __init__(self, *args: Any, **kwargs: Any) -> None: ... | |||
| def __init__(self, msg: str, hint: Optional[str] = ..., obj: Any = ..., id: Optional[str] = ...) -> None: ... | |||
There was a problem hiding this comment.
level is covered by the first call argument 👍
https://github.com/django/django/blob/e30d6678421b7573a1995f61521f14348c9b2a17/django/core/checks/messages.py#L10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
These classes pass all but the first argument through to
CheckMessage: https://github.com/django/django/blob/e30d6678421b7573a1995f61521f14348c9b2a17/django/core/checks/messages.py#L59-L81For type checking purposes it's best to redeclare all the arguments so they are type checked.
Related issues
n/a