Skip to content

Improve types for CheckMessage subclasses #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Improve types for CheckMessage subclasses #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions django-stubs/core/checks/messages.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ class CheckMessage:
def is_silenced(self) -> bool: ...

class Debug(CheckMessage):
def __init__(self, *args: Any, **kwargs: Any) -> None: ...
def __init__(self, msg: str, hint: Optional[str] = ..., obj: Any = ..., id: Optional[str] = ...) -> None: ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

level is covered by the first call argument 👍
https://github.com/django/django/blob/e30d6678421b7573a1995f61521f14348c9b2a17/django/core/checks/messages.py#L10


class Info(CheckMessage):
def __init__(self, *args: Any, **kwargs: Any) -> None: ...
def __init__(self, msg: str, hint: Optional[str] = ..., obj: Any = ..., id: Optional[str] = ...) -> None: ...

class Warning(CheckMessage):
def __init__(self, *args: Any, **kwargs: Any) -> None: ...
def __init__(self, msg: str, hint: Optional[str] = ..., obj: Any = ..., id: Optional[str] = ...) -> None: ...

class Error(CheckMessage):
def __init__(self, *args: Any, **kwargs: Any) -> None: ...
def __init__(self, msg: str, hint: Optional[str] = ..., obj: Any = ..., id: Optional[str] = ...) -> None: ...

class Critical(CheckMessage):
def __init__(self, *args: Any, **kwargs: Any) -> None: ...
def __init__(self, msg: str, hint: Optional[str] = ..., obj: Any = ..., id: Optional[str] = ...) -> None: ...