Rewrite SessionBase properties to use @property #1129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Follow-up to observation in: #1128 (comment)
Rewrite these properties to use
@property
.Tested by adding the below at the bottom of
django-stubs/contrib/sessions/backends/base.pyi
:Running Mypy without the fix:
...and after:
The correct types are revealed, and the assignment is detected as incorrect.
Related issues
n/a