Fix types for sessions #1173
Merged
Fix types for sessions #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljodal
commented
Sep 29, 2022
ljodal
force-pushed
the
fix/session-key-type
branch
from
50d2627 to
c8c6f05
Compare
|
I found some problems with |
Closed
This can be None, which type stubs no longer allow after typeddjango#1129
adamchainz
force-pushed
the
fix/session-key-type
branch
from
c8c6f05 to
ded4e33
Compare
sobolevn
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Thank you! Can you please run black to fix https://github.com/typeddjango/django-stubs/actions/runs/3385096206/jobs/5622845846 ?
|
I think I can enable |
|
Yes pre-commit.ci ftw! |
|
I guess my local pre-commit didn't get applied because this was a rebase commit, and git doesn't fire hooks during rebase 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session key can be None, which type stubs no longer allow after #1129, and the session_dict can be
dict[str, Any]