Skip to content

Missing converter: no-import-side-effect #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Oct 2, 2019 · 3 comments · Fixed by #239 or #271
Closed

Missing converter: no-import-side-effect #172

JoshuaKGoldberg opened this issue Oct 2, 2019 · 3 comments · Fixed by #239 or #271
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@JoshuaKGoldberg
Copy link
Member

💥 Missing Converter

  • tslint-to-eslint-config version: 1.2.0
  • typescript-eslint version: 2.3.2

TSLint Rule Name

no-import-side-effect

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments hacktoberfest labels Oct 2, 2019
@JoshuaKGoldberg
Copy link
Member Author

The issue here is that this package doesn't know how to convert the TSLint rule into the equivalent ESLint rule. Accepting PRs to add in a converter! 🙌

docs/Development.md has a root overview for how to get started. Within that, docs/Architecture.md#rule-converters talks about how these converters operate. Check the typescript-eslint roadmap to see suggestions on equivalent ESLint rules to convert to.

See #189 for an example of a simple rule converter that was recently added in.

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send in a PR to resolve this! ✨ label Oct 2, 2019
@bmeverett
Copy link
Contributor

I started taking a look at this. I noticed that the TSLint rule accepts a regex for paths to ignore and the ESLint accepts a glob relative to the files in the directory. Will we have to convert between the two or should we just include a notice that the path will have to be updated somehow.

@KingDarBoja
Copy link
Collaborator

I started taking a look at this. I noticed that the TSLint rule accepts a regex for paths to ignore and the ESLint accepts a glob relative to the files in the directory. Will we have to convert between the two or should we just include a notice that the path will have to be updated somehow.

Err I do recommend a notice on the meantime because the pattern cases could be hard to convert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
3 participants