add no-import-side-effect converter #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeverett
changed the title
bmeverett
force-pushed
the
no-import-side-effect
branch
from
196adb7 to
a963dcd
Compare
JoshuaKGoldberg
requested changes
Oct 19, 2019
JoshuaKGoldberg
added
the
status: waiting for author
JoshuaKGoldberg
requested changes
Oct 21, 2019
JoshuaKGoldberg
approved these changes
Oct 22, 2019
|
@bmeverett it doesn't look like eslint has a |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
I added the converter to convert the rule to ESLint. I didn’t try and convert the reflex to glob syntax. I can explore that if you feel it would be valuable.