Segmenter using ICU4C #461
Merged
+150
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-oly
commented
Jun 4, 2025
echeran
approved these changes
Jun 4, 2025
| json_object *options_obj = json_object_object_get(json_in, "options"); | ||
|
|
||
| json_object *granularity_obj = json_object_object_get(options_obj, "granularity"); | ||
| string granularity_value = json_object_get_string(granularity_obj); |
There was a problem hiding this comment.
Observation: granularity_value is an enum, but we're leaving it as a C++ string. We do properly convert enum values into Java enums in the ICU4J executor. Not for this PR but for the future, it would be better to convert enums into C++ enums.
Co-authored-by: Elango Cheran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some test case hacks to the generator to make some LINE segmentation pass. However, it doesn't pass with Chinese, Japanese, or Korean.
Note that the generator could be implemented with ICU4J to get better expected data.
Also, this depends on PR #458 , so cannot be submitted before that PR.