Add segmenter as test type for nodejs with minimal data #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeran
reviewed
May 15, 2025
There was a problem hiding this comment.
Please include segmenter.js in this PR.
Before doing that, given that it's absent, the CI job should not be succeeding. Let's make it fail appropriately first, and push the commits to Github to retrigger CI. After that, then include the file in the PR and push.
echeran
reviewed
May 19, 2025
Merged
|
Let's try to get this resolved soon. |
echeran
reviewed
Jun 2, 2025
echeran
reviewed
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.