Number format in ICU4X: add known issues and unsupported rounding modes #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested changes
Jun 23, 2025
Comment on lines
147
to
155
| # For datetime_fmt, is the format type "standard"? | ||
| at_strings = [' at', 'เวลา', ' هـ'] | ||
| if actual == expected: | ||
| return None | ||
| if actual.replace(' at', ',') == expected: | ||
| return knownIssueType.datetime_fmt_at_inserted | ||
| for at_string in at_strings: | ||
| if actual.replace(at_string, ',') == expected: | ||
| return knownIssueType.datetime_fmt_at_inserted | ||
| return None | ||
|
|
| # Number format known issues | ||
| def check_number_fmt_issues(test): | ||
| input = test['input_data']['input'] | ||
| if 'result' in test and test['result'] == '-' and abs(float(input)) < 1.0: |
There was a problem hiding this comment.
Suggestion: this should check for ICU4X, Compact, and abs(float(input)) < 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reclassifies all but one test failure in ICU4X number format. That test will be handled when PR #458 is submitted.