Fix latency units display from ms to s #256
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaltheCow
approved these changes
Aug 6, 2025
Signed-off-by: tjandy98 <[email protected]>
## Summary <!-- Include a short paragraph of the changes introduced in this PR. If this PR requires additional context or rationale, explain why the changes are necessary. --> This PR adds templates for issues and pull requests. This helps maintainers by encouraging users/contributors to provide all necessary information. ## Details <!-- Provide a detailed list of all changes introduced in this pull request. --> - [x] Add issue templates from [llm-compressor](https://github.com/vllm-project/llm-compressor) - [x] Add a PR template ## Test Plan <!-- List the steps needed to test this PR. --> - Open a PR or issue using the given templates --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [ ] Includes AI-assisted code completion - [x] Includes code generated by an AI application - [ ] Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes `## WRITTEN BY AI ##`) ## External Sources - [x] Other compatible open source projects --------- Signed-off-by: Samuel Monson <[email protected]> Signed-off-by: tjandy98 <[email protected]>
I just wanted to touch this up a little so we can close out this issue: vllm-project#209 Signed-off-by: dalthecow <[email protected]> Co-authored-by: Samuel Monson <[email protected]> Signed-off-by: tjandy98 <[email protected]>
## Summary The local html report was broken on firefox. There is some issue caused by Next.js. I tried many things and finally fixed it by downgrading the version from 15 to 13. Other changes in here include removing dynamic exports which have long been unneeded and were contributing to the firefox issues. Also after downgrading versions there were other things that broke that have been updated here. I'll report the issue with Next.js 15 and hopefully this can be further investigated so we can upgrade again in the future. ## Details - Remove most of the dynamic exports - Downgrade from Next.js 15.3.4 to 13.4.0. - Fix ensuing issues created by downgrade including eslint.config.js issues, change next config from .ts to .mjs, add experimental esmExternals config option, remove cypress lint config globals as they were breaking. ## Test Plan - Mostly just need to get all of the checks passing and ensure cypress tests still function. The app works in firefox now. --- "I certify that all code in this PR is my own, except as noted below." ## Use of AI None Signed-off-by: dalthecow <[email protected]> Signed-off-by: tjandy98 <[email protected]>
tjandy98
force-pushed
the
update-ui-units
branch
from
e7e4c7c to
da6fecf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.