Skip to content

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Mar 11, 2025

Purpose

  • Introduce SupportsQuant which
    • Initializes the quant_config attribute and updates the quant_config with the relevant packed_modules_mapping
    • Marks a model as being capable of supporting quantized inference
    • In the future, will check if a model has been correctly defined, for example if prefixes and quant_configs have been passed correctly
    • In the future, may remap ignored_modules according to the hf_to_vllm_mapper
  • This mixin will replace the configure_quant_config function after it has been added to a sufficient number of models
  • These changes reflect the issue that configure_quant_config assumes that all packed_modules_mappings will be declared prior to initialization. In reality, some models are submodels of each other, so their mappings can only be determined at init time.
    • Using a mixin which updates after class is initialized but the mapping before the parameters init guarantees that the config is up to date w.r.t. mappings before the parameters init

Related PRs

Signed-off-by: Kyle Sayers <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs changed the title [WIP] Add SupportsQuant and packed_modules_mapping to all models [Quant] Add SupportsQuant and packed_modules_mapping to all models Mar 12, 2025
@mergify mergify bot added the llama Related to Llama models label Jun 11, 2025
Copy link

mergify bot commented Jun 11, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @kylesayrs.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jun 11, 2025
@mergify mergify bot added the qwen Related to Qwen models label Jun 19, 2025
@mergify mergify bot added the deepseek Related to DeepSeek models label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deepseek Related to DeepSeek models llama Related to Llama models needs-rebase qwen Related to Qwen models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant