Skip to content

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Apr 2, 2025

Purpose

  • Introduce SupportsQuant mixin to models in order to uniformity support quantization across all models
    • packed_modules_mapping is correctly updated across nested models
    • ignored modules are correctly updated according to hf_to_vllm_mapper and across nested models

Related Issues

Changes

  • Add SupportsQuant and packed_modules_mapping attribute to Chameleon, Chatglm, and Commandr
  • Note that the packed_modules_mapping is already defined on the Chatglm inherited class, not the base class

Copy link

github-actions bot commented Apr 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented Apr 2, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @kylesayrs.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@kylesayrs kylesayrs closed this Apr 2, 2025
@kylesayrs kylesayrs force-pushed the kylesayrs/chameleon-SupportsQuant branch from 009eaba to a79cc68 Compare April 2, 2025 16:40
Signed-off-by: Kyle Sayers <[email protected]>
@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend structured-output v1 labels Apr 2, 2025
Signed-off-by: Kyle Sayers <[email protected]>
@vllm-bot vllm-bot merged commit 82e7e19 into vllm-project:main Apr 3, 2025
12 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation frontend structured-output v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants