Skip to content

[Misc] remove unused script #15746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

[Misc] remove unused script #15746

merged 1 commit into from
Apr 1, 2025

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Mar 29, 2025 •
edited by github-actions bot
Loading

According to the PR history, it is not used python_only_dev.py to install since #9621 updated, and it should no another scripts or others to call this script(pls correct me if i missed something), so try to remove.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@reidliu41 reidliu41 mentioned this pull request Apr 1, 2025
Closed
hmellor
hmellor approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hmellor hmellor enabled auto-merge (squash) April 1, 2025 13:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 1, 2025
@jeejeelee
Copy link
Collaborator

Thank you for your contribution

@hmellor hmellor merged commit 2e45bd2 into vllm-project:main Apr 1, 2025
24 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@reidliu41 @Alex4210987
[Misc] remove unused script (vllm-project#15746)
b588449 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@reidliu41 @lulmer
[Misc] remove unused script (vllm-project#15746)
b72a115 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @lk-chen
[Misc] remove unused script (vllm-project#15746)
905371a 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@reidliu41 @shreyankg
[Misc] remove unused script (vllm-project#15746)
6ad6637 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@reidliu41
[Misc] remove unused script (vllm-project#15746)
b310cde 
Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidliu41 @jeejeelee @hmellor