Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 1, 2025

  • Reduces cause for confusion
  • Reduces clutter in root directory

Copy link

github-actions bot commented Apr 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@reidliu41
Copy link
Contributor

actually, I posted 3 days ago, #15746 but no one reviewed..

@hmellor
Copy link
Member Author

hmellor commented Apr 1, 2025

Sorry @reidliu41, I hadn't seen your PR. I'll close mine in favour of yours!

@hmellor hmellor closed this Apr 1, 2025
@hmellor hmellor deleted the remove-python-only-dev branch April 1, 2025 13:29
@reidliu41
Copy link
Contributor

it's ok, thanks

@reidliu41
Copy link
Contributor

@hmellor and I see your docker move done, looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants