-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Skip device and quant Pydantic validation to make plugin device work #18843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Yikun Jiang <[email protected]>
c02dc75
to
d98edcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution is fine as a hotfix. In future it might be nicer to implement our own Pydantic validator that doesn't error if it detects a plugin device
CI passed, it's ready to go. |
FYI this argument has been deprecated by #18399 |
@DarkLight1337 ci passed, hope can merge |
Can you also skip the validation for the quantization method to fix the failing quant test shown in #18852? Then I'll force-merge this |
Head branch was pushed to by a user without write access
Signed-off-by: Yikun Jiang <[email protected]>
c2fec6b
to
47e83f2
Compare
…llm-project#18843) Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: amit <[email protected]>
What this PR does / why we need it?
Since 4c2b38c , it converted configs to Pydantic dataclasses and enable Pydantic checks. Due to config.Device has strict validation, run the model test on the plugin device (vllm-ascend in my case) will not work and raise the error:
See also here: https://github.com/vllm-project/vllm-ascend/actions/runs/15303026138/job/43048387981?pr=958
This patch try to resolve it by skip device field validation to make plugin device work.
How was this patch tested?