Skip to content

Conversation

ProExpertProg
Copy link
Collaborator

@ProExpertProg ProExpertProg commented May 28, 2025

Update pydantic to fix error on python 3.10.

FIX issue from #17599.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 28, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure if the pip-compile pre-commit hook will complain about this not being updated in requirements/test.txt

@ProExpertProg
Copy link
Collaborator Author

Yeah I saw that - it seems like 2.9 is pulled in via other packages, should we make it explicitly 2.10 in test.in?

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
@hmellor
Copy link
Member

hmellor commented May 29, 2025

It's not causing a problem so it'd technically be fine to leave it. But we might want to set a lower bound there as well for consistency.

@DarkLight1337
Copy link
Member

The quantization test is still failing

@DarkLight1337
Copy link
Member

Closing this in favor of #18843

@jeejeelee jeejeelee reopened this May 29, 2025
@DarkLight1337
Copy link
Member

Sorry I missed the context of this PR! Can you merge from main to fix the CI failures?

@DarkLight1337
Copy link
Member

Actually let me just force-merge this

@vllm-bot vllm-bot merged commit f274581 into vllm-project:main May 29, 2025
102 of 106 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants