-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[BugFix] Update pydantic to fix error on python 3.10 #18852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: luka <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure if the pip-compile pre-commit hook will complain about this not being updated in requirements/test.txt
Yeah I saw that - it seems like 2.9 is pulled in via other packages, should we make it explicitly 2.10 in test.in? |
It's not causing a problem so it'd technically be fine to leave it. But we might want to set a lower bound there as well for consistency. |
The quantization test is still failing |
Closing this in favor of #18843 |
Sorry I missed the context of this PR! Can you merge from main to fix the CI failures? |
Actually let me just force-merge this |
) Signed-off-by: luka <[email protected]> Signed-off-by: amit <[email protected]>
Update pydantic to fix error on python 3.10.
FIX issue from #17599.