-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
add lineinfo for all cuda device compilations #23021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add lineinfo for all cuda device compilations #23021
Conversation
Signed-off-by: Wenchen Lo <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the -lineinfo
NVCC flag to enable line number information for debugging and profiling CUDA kernels. The change is correct, but I've suggested making it conditional based on the CMake build type to avoid impacting release builds. This aligns with best practices for managing build configurations.
if(VLLM_GPU_LANG STREQUAL "CUDA") | ||
list(APPEND VLLM_GPU_FLAGS "-lineinfo") | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding -lineinfo
is useful for debugging and profiling, adding it unconditionally to all build types, including Release
, is not standard practice. This can increase binary size and may have a minor performance impact on production builds.
It's better to enable this flag for debug-related build types only (e.g., Debug
, RelWithDebInfo
, or any build type except Release
). This gives developers control over the trade-off between debuggability and performance/size.
if(VLLM_GPU_LANG STREQUAL "CUDA" AND NOT (CMAKE_BUILD_TYPE STREQUAL "Release"))
list(APPEND VLLM_GPU_FLAGS "-lineinfo")
endif()
@@ -164,6 +164,13 @@ endif() | |||
# | |||
get_torch_gpu_compiler_flags(VLLM_GPU_FLAGS ${VLLM_GPU_LANG}) | |||
|
|||
# | |||
# Add line info for debugging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Add line info for debugging. | |
# Add line info for cuda core dump. |
Purpose
To resolve #22958, add -lineinfo in NVCC flags
Test Plan
WIP
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.