Skip to content

add lineinfo for all cuda device compilations #23021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Draft

add lineinfo for all cuda device compilations #23021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,13 @@ endif()
#
get_torch_gpu_compiler_flags(VLLM_GPU_FLAGS ${VLLM_GPU_LANG})

#
# Add line info for debugging.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add line info for debugging.
# Add line info for cuda core dump.

#
if(VLLM_GPU_LANG STREQUAL "CUDA")
list(APPEND VLLM_GPU_FLAGS "-lineinfo")
endif()
Comment on lines +170 to +172
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding -lineinfo is useful for debugging and profiling, adding it unconditionally to all build types, including Release, is not standard practice. This can increase binary size and may have a minor performance impact on production builds.

It's better to enable this flag for debug-related build types only (e.g., Debug, RelWithDebInfo, or any build type except Release). This gives developers control over the trade-off between debuggability and performance/size.

if(VLLM_GPU_LANG STREQUAL "CUDA" AND NOT (CMAKE_BUILD_TYPE STREQUAL "Release"))
  list(APPEND VLLM_GPU_FLAGS "-lineinfo")
endif()


#
# Set nvcc parallelism.
#
Expand Down