-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Core] Remove tokenizer group in vLLM #24078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…basic example Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Zhuohan Li <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Zhuohan Li <[email protected]>
xuechendi
pushed a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Sep 17, 2025
vllm-project/vllm#24795 and vllm-project/vllm#24615 and vllm-project/vllm#24078 --------- Signed-off-by: Agata Dobrzyniewicz <[email protected]>
5 tasks
slokesha
pushed a commit
to slokesha/vllm-gaudi
that referenced
this pull request
Sep 24, 2025
vllm-project/vllm#24795 and vllm-project/vllm#24615 and vllm-project/vllm#24078 --------- Signed-off-by: Agata Dobrzyniewicz <[email protected]> Signed-off-by: slokesha <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Zhuohan Li <[email protected]>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Zhuohan Li <[email protected]> Signed-off-by: charlifu <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Zhuohan Li <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Zhuohan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
frontend
llama
Related to Llama models
performance
Performance-related issues
ready
ONLY add when PR is ready to merge/full CI is needed
structured-output
tool-calling
v1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Tokenizer group is an abstraction introduced in early day vLLM to support the case where different LoRA adapters use different tokenizers. Looking back, LoRA is a niche feature among all vLLM users, and different tokenizers for different LoRAs is a "niche of the niche" feature. However, This niche of the niche feature spreads all around in vLLM code base, which becomes technical debt.
In the long term, I believe it's a good idea to eliminate the use of tokenizer in vLLM core and make most part of the core only works on token-IDs. This reduces our coupling with huggingface tokenizer and will make developing vLLM core easier.
Also see #23474 #23540
Test Plan
Make sure all the existing tests pass.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.