Skip to content

Conversation

zhuohan123
Copy link
Member

@zhuohan123 zhuohan123 commented Sep 2, 2025

Purpose

Tokenizer group is an abstraction introduced in early day vLLM to support the case where different LoRA adapters use different tokenizers. Looking back, LoRA is a niche feature among all vLLM users, and different tokenizers for different LoRAs is a "niche of the niche" feature. However, This niche of the niche feature spreads all around in vLLM code base, which becomes technical debt.

In the long term, I believe it's a good idea to eliminate the use of tokenizer in vLLM core and make most part of the core only works on token-IDs. This reduces our coupling with huggingface tokenizer and will make developing vLLM core easier.

Also see #23474 #23540

Test Plan

Make sure all the existing tests pass.

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added documentation Improvements or additions to documentation frontend structured-output v1 labels Sep 2, 2025
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
@mergify mergify bot added the performance Performance-related issues label Sep 2, 2025
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
Signed-off-by: Zhuohan Li <[email protected]>
@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 3, 2025
@mergify mergify bot added the needs-rebase label Sep 15, 2025
@zhuohan123 zhuohan123 enabled auto-merge (squash) September 16, 2025 23:27
@mergify mergify bot removed the needs-rebase label Sep 16, 2025
Signed-off-by: Zhuohan Li <[email protected]>
Copy link

mergify bot commented Sep 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @zhuohan123.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 17, 2025
@mergify mergify bot removed the needs-rebase label Sep 17, 2025
Copy link

mergify bot commented Sep 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @zhuohan123.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 17, 2025
@mergify mergify bot removed the needs-rebase label Sep 17, 2025
@zhuohan123 zhuohan123 merged commit 6c47f6b into main Sep 17, 2025
56 checks passed
@zhuohan123 zhuohan123 deleted the zhuohan/remove-token-group branch September 17, 2025 08:43
xuechendi pushed a commit to vllm-project/vllm-gaudi that referenced this pull request Sep 17, 2025
slokesha pushed a commit to slokesha/vllm-gaudi that referenced this pull request Sep 24, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation frontend llama Related to Llama models performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed structured-output tool-calling v1

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants