[CI Bugfix] Fix failing test_model_load_with_params tests due to tokenizer refactor #25086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mgoin <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates tests in tests/model_executor/test_model_load_with_params.py to align with a recent tokenizer refactoring. The changes correctly modify how the tokenizer's name and model_max_length are accessed in the test assertions. Specifically, model_tokenizer.tokenizer_id is replaced with model_config.tokenizer, and model_tokenizer.tokenizer.model_max_length is simplified to model_tokenizer.model_max_length. The changes are correct and necessary to fix the failing tests. I have no further recommendations.
mgoin
added
ready
mgoin
changed the title
debroy-rh
pushed a commit
to debroy-rh/vllm
that referenced
this pull request
Sep 19, 2025
…nizer refactor (vllm-project#25086) Signed-off-by: mgoin <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…nizer refactor (vllm-project#25086) Signed-off-by: mgoin <[email protected]>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
…nizer refactor (vllm-project#25086) Signed-off-by: mgoin <[email protected]> Signed-off-by: charlifu <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…nizer refactor (vllm-project#25086) Signed-off-by: mgoin <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…nizer refactor (vllm-project#25086) Signed-off-by: mgoin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes broken Model Executor Test https://buildkite.com/vllm/ci/builds/31128/steps/canvas?sid=019957f9-c884-4158-85bd-309efbb5f140 since #24078
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.