Skip to content

Refactor find to return the root in single root element components, fix #7 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2020

Conversation

dobromir-hristov
Copy link
Contributor

closes #7

@dobromir-hristov dobromir-hristov self-assigned this Mar 29, 2020
@dobromir-hristov dobromir-hristov changed the title Refactor find to return the root in single root element components Refactor find to return the root in single root element components, fix #7 Mar 29, 2020
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to hit submit review a few das ago :|

@dobromir-hristov
Copy link
Contributor Author

Comments fixed :)

@lmiller1990 lmiller1990 merged commit dd4a348 into master Mar 31, 2020
@lmiller1990 lmiller1990 deleted the fix/allow-find-on-root branch March 31, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find and findAll
3 participants