-
Notifications
You must be signed in to change notification settings - Fork 264
update setValue to work with any input type #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice progress. left some small comments, we can type this properly once the implementation working - happy to just tsignore things until it's all passing, then pretty it up. Great!
Co-Authored-By: Adrià Fontcuberta <[email protected]>
Co-Authored-By: Adrià Fontcuberta <[email protected]>
…ue-test-utils-next into feature/update-set-value � Conflicts: � src/dom-wrapper.ts
@dobromir-hristov still has the WIP label - are you still working on this, or wanting a review/merge? |
Nope i am done |
tests/setValue.spec.ts
Outdated
expect(wrapper.text()).toContain('selectA') | ||
}) | ||
|
||
it.skip('does not select an already selected element', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this one work?
it.skip('does not select an already selected element', async () => { | |
it('does not select an already selected element', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not make this work :/
tests/setValue.spec.ts
Outdated
expect(wrapper.find<HTMLInputElement>('.counter').text()).toBe('4') | ||
}) | ||
|
||
it.skip('does not trigger a change event if the checkbox is already checked', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it.skip('does not trigger a change event if the checkbox is already checked', async () => { | |
it('does not trigger a change event if the checkbox is already checked', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find was not returning the root node, so this was not working, and VueWrapper no longer has the set methods. Did we merge find
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, do you mean #36?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw yeah, will fix it now :)
Ok I removed "WIP" from the title, I'll play around with it a bit tonight! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closes #29