Skip to content

update setValue to work with any input type #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 3, 2020

Conversation

dobromir-hristov
Copy link
Contributor

@dobromir-hristov dobromir-hristov commented Mar 30, 2020

Closes #29

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice progress. left some small comments, we can type this properly once the implementation working - happy to just tsignore things until it's all passing, then pretty it up. Great!

@dobromir-hristov dobromir-hristov marked this pull request as ready for review March 31, 2020 09:15
@lmiller1990
Copy link
Member

@dobromir-hristov still has the WIP label - are you still working on this, or wanting a review/merge?

@dobromir-hristov
Copy link
Contributor Author

Nope i am done

expect(wrapper.text()).toContain('selectA')
})

it.skip('does not select an already selected element', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this one work?

Suggested change
it.skip('does not select an already selected element', async () => {
it('does not select an already selected element', async () => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not make this work :/

expect(wrapper.find<HTMLInputElement>('.counter').text()).toBe('4')
})

it.skip('does not trigger a change event if the checkbox is already checked', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it.skip('does not trigger a change event if the checkbox is already checked', async () => {
it('does not trigger a change event if the checkbox is already checked', async () => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find was not returning the root node, so this was not working, and VueWrapper no longer has the set methods. Did we merge find ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, do you mean #36?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw yeah, will fix it now :)

@lmiller1990 lmiller1990 changed the title WIP: update setValue to work with any input type update setValue to work with any input type Apr 2, 2020
@lmiller1990
Copy link
Member

Ok I removed "WIP" from the title, I'll play around with it a bit tonight!

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lmiller1990 lmiller1990 merged commit 99a34c9 into master Apr 3, 2020
@lmiller1990 lmiller1990 deleted the feature/update-set-value branch April 3, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOMWrapper: setValue
5 participants