update setValue to work with any input type #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
reviewed
Mar 30, 2020
afontcu
reviewed
Mar 30, 2020
lmiller1990
reviewed
Mar 31, 2020
Co-Authored-By: Adrià Fontcuberta <[email protected]>
Co-Authored-By: Adrià Fontcuberta <[email protected]>
…ue-test-utils-next into feature/update-set-value � Conflicts: � src/dom-wrapper.ts
afontcu
reviewed
Apr 1, 2020
|
@dobromir-hristov still has the WIP label - are you still working on this, or wanting a review/merge? |
|
Nope i am done |
afontcu
reviewed
Apr 2, 2020
tests/setValue.spec.ts
Outdated
| expect(wrapper.text()).toContain('selectA') | ||
| }) | ||
|
|
||
| it.skip('does not select an already selected element', async () => { |
There was a problem hiding this comment.
should this one work?
Suggested change
| it.skip('does not select an already selected element', async () => { | |
| it('does not select an already selected element', async () => { |
There was a problem hiding this comment.
I could not make this work :/
afontcu
reviewed
Apr 2, 2020
tests/setValue.spec.ts
Outdated
| expect(wrapper.find<HTMLInputElement>('.counter').text()).toBe('4') | ||
| }) | ||
|
|
||
| it.skip('does not trigger a change event if the checkbox is already checked', async () => { |
There was a problem hiding this comment.
Suggested change
| it.skip('does not trigger a change event if the checkbox is already checked', async () => { | |
| it('does not trigger a change event if the checkbox is already checked', async () => { |
There was a problem hiding this comment.
Find was not returning the root node, so this was not working, and VueWrapper no longer has the set methods. Did we merge find ?
There was a problem hiding this comment.
I saw yeah, will fix it now :)
lmiller1990
changed the title
|
Ok I removed "WIP" from the title, I'll play around with it a bit tonight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29