Skip to content

Copy [[pending promises]] wording from WebAudio #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chcunningham opened this issue Feb 8, 2021 · 2 comments · Fixed by #268
Closed

Copy [[pending promises]] wording from WebAudio #136

chcunningham opened this issue Feb 8, 2021 · 2 comments · Fixed by #268
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior

Comments

@chcunningham
Copy link
Collaborator

Splitting of feedback from this PR
#112 (comment)

The PR introduced a concept of "Injected State" to hold the promises for queued actions. A list of pending promises is simpler.
https://www.w3.org/TR/webaudio/#dom-baseaudiocontext-pending-promises-slot
@chcunningham chcunningham added the editorial changes to wording, grammar, etc that don't modify the intended behavior label Feb 8, 2021
@chcunningham chcunningham mentioned this issue Feb 8, 2021
Merged
@chcunningham
Copy link
Collaborator Author

Also, rejecting these promises for reset() should probably reject with an AbortError DOMException.

@chcunningham
Copy link
Collaborator Author

Also, rejecting these promises for reset() should probably reject with an AbortError DOMException.

Tracked by #188. Lets focus this issue just on [[pending promises]]

chcunningham added a commit that referenced this issue Jun 4, 2021
@chcunningham
Add exceptions to pending flush() promises.
26c5165 
This unifies on behavior with ImageDecoder in providing some indication
about why the flush was aborted.

Fixes #188.
Fixes #136.
@chcunningham chcunningham mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add exceptions to pending flush() promises. w3c/webcodecs
1 participant
@chcunningham