-
-
Notifications
You must be signed in to change notification settings - Fork 629
test: enable tests for webpack-dev-server@beta-1
#2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need update snapshot resolver to include |
22dacde
to
e812a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need snapshot resolver here, for webpack-dev-server v3 and webpack-dev-server v4, and for webpack v4 and v5
Yep WIP. |
28e9d62
to
cb804c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2573 +/- ##
==========================================
+ Coverage 95.20% 95.70% +0.50%
==========================================
Files 30 30
Lines 1501 1491 -10
Branches 429 429
==========================================
- Hits 1429 1427 -2
+ Misses 72 64 -8
Continue to review full report at Codecov.
|
a6ab043
to
af80baa
Compare
Ideally we should run it on the next |
I will finish it, anyway good job, big thanks |
0d2db79
to
20779a2
Compare
Again, tests with changing directory and do not return to default state... |
@snitin315 Do you have idea where we have tests which change |
lets try to skip them and see if CI passes |
6dd7dff
to
9e666e8
Compare
I can't understand which part of code change our cwd 😞 |
Found it is in @webpack/cli-team We need rewrite these test on standard tests, somebody want to help? We need do it in other PR |
due |
I just drop them to test it here |
package.json
Outdated
@@ -82,9 +82,9 @@ | |||
"ts-jest": "^26.4.3", | |||
"ts-node": "^9.1.1", | |||
"typescript": "^4.1.3", | |||
"webpack": "^5.25.0", | |||
"webpack": "^4.46.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't change
need to update some snapshots, I think it looks good now |
Merging is hell |
580069c
to
68761e6
Compare
Hope all will be fine now and we can finish it, found some bug on webpack-dev-server side |
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information
No